Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Version replacement in feature.xml 
Did some digging and found this commit [1] where I originally introduced
this feature. Looks like I wanted to have the same expansion logic both
for feature.xml and site.xml, and '1.2.3' was (still is?) site.xml
understood but feature.xml didn't.
[1] https://github.com/sonatype/sonatype-tycho/commit/87b6949e1f11740620414500f2d081c35bcca41d 

--
Regards,
Igor

On 2014-05-30, 10:39, Oberlies, Tobias wrote:

For bug 352081 <https://bugs.eclipse.org/bugs/show_bug.cgi?id=352081>,
I’m currently re-implementing/testing some of the version replacement
logic in feature.xml, and I’m wondering what the use cases for the
current logic are.

The current behaviour is summarized in the class DependencyArtifacts:

  * 0.0.0 or null matches the latest version
  * 1.2.3, i.e. without a qualifier, is equivalent to [1.2.3,1.2.4) and
    matches 1.2.3 with the latest qualifier.
  * 1.2.3.qualifier, i.e. literal "qualifier", is equivalent to
    [1.2.3,1.2.4) and matches 1.2.3 with the latest qualifier.
  * all other versions match artifact with that exact version, 1.2.3.foo
    is equivalent to [1.2.3.foo]

The cases 0.0.0, 1.2.3.qualifier, and four segment versions are clear to
me – these cases occur during normal editing with the PDE UI editors.

However I don’t understand what the special handling of three segment
versions is needed for? Was this PDE Build behaviour? PDE UI doesn’t
seem to consider three segment versions to be a special – it shows a
warning for 1.2.3 even when there is a version [1.2.3,1.2.4) in the
target platform.

@Igor: Do you remember why this was done this way? Do you have strong
feelings about dropping this case?

Regards

Tobias



_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev

Back to the top