| Re: [tracecompass-dev] Important for contributors: Directory layout change in master |
Hello Alex
I understand why the set of patches were pushed directly. It was to push all patches at the same time, kind of in an atomic operation. Using Gerrit there would have been a window for developers to fetch from the repository with only a subset of the patches available. I'm ok with this exception of the usual review process in this special case. However, I would have liked that all the patches had been approved and verified on Gerrit before the actual direct push.
/Bernd
On 06/18/2015 02:19 PM, Matthew Khouzam wrote:
On 15-06-18 11:50 AM, Alexandre Montplaisir wrote:
On 2015-06-18 10:26 AM, Matthew Khouzam wrote:I am not implying, but rather stating that gerrrit IMO is more
Just to clarify, if some people are wondering why the patches went inThe Git repo is just as public and visible as Gerrit. I fail to see
without a proper review, the answer is, they were reviewed. They were
pushed atomically as a branch outside of gerrit. This is not the
standard way of working though, we pretty much always review on gerrit
as we are striving for as much transparency as possible in the project.
how it lacks transparency, as you seem to imply.
transparent as it keeps a record of the review process, whereas git
records the content, in patch form. When a patch is submitted, it does
not simply go into the branch, but we have at least two committers OK
the patch. The process of review is public and transparent, we don't go
into a Dr Strangelove like war room (also we can't afford one) to review
code and merge it without a record of what happened.
Every -1 with subsequent iteration is important as it shows not only
what gets in but also what does not and why.
Cheers,
Matthew
_______________________________________________BR_______________________________________________
Matthew
On 15-06-16 03:57 PM, Alexandre Montplaisir wrote:
Hi all,_______________________________________________
We have just merged a major directory layout change in the master
branch. All plugin directories are now categorized within
sub-directories. For more details, see the discussion at [1].
This means that any previous Eclipse workspace used for development
will have to be updated to point to the new locations. To do so, you
have to delete everything org.eclipse.tracecompass.* in your
workspace, re-import the directory again, and then re-set the target
and API baseline.
If you are not sure, simply delete everything and redo the steps
described in [2].
Let us know if you hit unforeseen problems.
Thanks,
Alexandre
[1] http://dev.eclipse.org/mhonarc/lists/tracecompass-dev/msg00126.html
[2]
https://wiki.eclipse.org/Trace_Compass/Development_Environment_Setup
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev