[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [recommenders-dev] [Please Help] Problems in pushing new code to Gerrit

Can you tell which commit is actually not yet in the blessed repository [1]? I see 7 commits already pushed which cannot (easily) be reverted anymore. Actually, I'd say if there is anything to correct just do a new commit that brings everything in a good shape and try to use gerrit properly in this commit. Just abandon the other changes if they are already merged. You probably already know the EGit guide section about working with Gerrit [2].

Best,
Marcel

[1] https://git.eclipse.org/c/recommenders.incubator/org.eclipse.recommenders.args.git
[2] http://wiki.eclipse.org/EGit/User_Guide#Working_with_Gerrit

On May 13, 2013, at 4:50 PM, <tong.wu.stap@xxxxxxxxx> wrote:

Hi Marcel:
   Thank you very much for your help.

   Iâm so sorry for pushing changes directly to refs/heads/master. At that time I didnât know push to master will avoid the review.  We will abandon these changes.
   Thereâs a change containing old code that has not been accepted (https://git.eclipse.org/r/#/c/10681/), and we want to push our new code to Gerrit. How should we do now? Abandon the change and push another new change?

Thanks!
 
Best,
Tong 
 
 
åää: Marcel Bruch
åéæé: â2013âåâ5âæâ13âæ â21â:â49
æää: Recommenders developer discussions
äé: Re: [recommenders-dev] [Please Help] Problems in pushing new code to Gerrit
 
Hi Tong,

On May 13, 2013, at 1:46 PM, tong.wu.stap@xxxxxxxxx wrote:
>  At first, we just used push like this: 
>  git push ssh://username@xxxxxxxxxxxxxxx:29418/(project).git HEAD:refs/for/master
 
>  It seems we pushed our change to repo successfully, but when we checked this page (https://git.eclipse.org/r/#/c/10681/), we found nothing changed. So we tried several other methods, like add change-id, and tried to push several times.


the webpage says:
 â Need Verified
 â Need Code-Review
 â Need IP-Clean


I guess that you know that what every you push to Gerrit's "refs/for/*" needs to be reviewed and accepted by  a committer, i.e., someone has to press the "Review" button and approve the change set when satisfied. Please check [1] and related sections for details on how to approve a change and finally push the commit to the blessed repository.

[2] shows me that you pushed these changes to the repository already without going through the review cycle (i.e., not pushing to refs/for/master but directly to refs/heads/master). If this is what you agreed to, that's fine. We usually let someone else look at /review the commit before accepting it.


> Then we found actually we had made some changes on Gerrit, because when we tried to clone the project it was the latest one and also we found this page (https://git.eclipse.org/r/#/c/12736/). Unfortunately there are some useless commits and no source files which should be reviewed by other committers. For the moment we have no idea how to solve this problem. We want to show the new code to others and remove those useless commits. Could you help us? 

You mean the one in Gerrit? How about pressing "abandon change" on the change-set summary page?

Best,
Marcel

[1] http://wiki.eclipse.org/Gerrit#To_approve_a_change
[2] https://git.eclipse.org/c/recommenders.incubator/org.eclipse.recommenders.args.git/


> 
>  Thank you very much!
> 
> Best wishes,
> Tong
 
> _______________________________________________
> recommenders-dev mailing list
> recommenders-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/recommenders-dev

-- 
Codetrails UG (haftungsbeschrÃnkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Mobile: 0179 131 77 21
http://www.codetrails.com

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940

_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev

-- 
Codetrails UG (haftungsbeschrÃnkt)
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Mobile: 0179 131 77 21
http://www.codetrails.com

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940