Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [recommenders-dev] Fwd: [Bug 383511] Enable Gerrit for recommenders.incubator/org.eclipse.recommenders.codesearch.git

Here it is, I just committed a Tycho-enabled version of my plugin. Basically I took another labs contribution as a stub, the build can be started from the pom.xml in the root of code-recommenders.codesearch-massimo repository, let me know if everything's ok, I just run a test build on my machine and it worked fine. I want to add a +1 for Tycho! Let me say it's very powerful and although I had little experience with Maven it took me a relatively small effort to set up a basic build. I think it's really a great addition to the Eclipse build system, I had some experience with the PDE builder and it was far more complicated to set up and run.

Enjoy your weekend :)
Massimo.

On Mon, Jul 23, 2012 at 5:59 AM, Marcel Bruch <marcel.bruch@xxxxxxxxx> wrote:
Hi Massimo, 

Thanks for the update. I'm very much looking forward to it. 
If there is anything I can do, let me know.

Best,
Marcel


On 22.07.2012, at 17:57, Massimo Zugno wrote:

Hi,
quick update, just to let you know I'm still working on the feature :) (unfortunately I've been sick this week)... Anyway I'm currently setting up the Tycho build, I'm using one of the labs' google repo as a stub, it will probably take me some time since I'm not much experienced on Tycho builds. I'll let you know if I'm stuck :)

Enjoy your weekend :)
Massimo.

On Tue, Jul 10, 2012 at 6:22 PM, Marcel Bruch <marcel.bruch@xxxxxxxxx> wrote:
Hi Massimo,

I've create your codesearch repository at eclipselabs [1]. Please check out how to access and push to this repo (passwords etc. can be configured in your personal settings at google code). Put in there whatever you need.

If you set up a maven tycho based build, I'll add a build job on our build server and add a link to your definition recommender to Recommenders' "labs channel" repository [2] to allow others to pick up your prototypes for testing.

Regarding index size:
I don't mind the index size ;) We'll put a warning on the preference page and website to tell people that the index gets quite large. But as disc capacity is cheap I don't think that too many people would mind. Especially not if they save hours of development time because of your definition recommender ;)

Regarding rendering:
- user select a type
* display initial information about the selection
- search is performed in the background thread
* display search results

Just a spontaneous und unreflected thought. We may use the same annotations based approach for render methods, i.e.,

@JavaElementSelection
 render(IType type){...}

This way it becomes little easier to separate both phases.

However, it's still not very clean I think...

Still thinking ;)
Marcel






On 10.07.2012, at 18:16, Massimo Zugno wrote:

Hi Marcel,
no problem in using this email. 
Just a correction on a mistake I made on my previous post: the size of the index is actually more than 200mb, I mistakenly picked that 37mb from a zip I made of my index. Apart from this I could start investigating for a way to store the expressions in the index, this would boost the performance of the search and hopefully won't be too heavy on disk space usage... It would make a sensible difference: the search itself is extremely fast.
Tonight I'll make a screenshot of what I've on the plate so far and I'll spread it across the internet :D

More generally speaking, I kept thinking about improving the "render" phase of the extdoc provider. The more I thought about it and the more the problem seems to be not so simple. The problem is that typically we need different "render phases". For example, in my case:
- user select a type
* display initial information about the selection
- search is performed in the background thread
* display search results

I had no chance to tackle this problem yet, but maybe you have some suggestions!

Thanks,
Massimo.

On Tue, Jul 10, 2012 at 3:07 PM, Marcel Bruch <bruch@xxxxxxxxxxxxxxxxxx> wrote:

On 10.07.2012, at 16:03, Marcel Bruch wrote:

> If you agree, please send me your gmail address so that I can set up the repository for you.

Well... I got it already :) Let me know if using this one would work for you.
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev

_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev


_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev


_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev


_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/recommenders-dev



Back to the top