[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-ui-dev] I need help building with a gson dependency

I have added the gson dependency to that file Mickael [1]. I cannot create a CQ because only committers can do that. What do you need from me to create that CQ?

Alternatively, we can _include_ minimal json [2] as a fat jar (33kb) inside this bundle. We would not need to change the global dependency file and you can create a piggyback CQ for minimal json.

Let me know what you think is best.

[1] https://git.eclipse.org/r/#/c/118574/
[2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=15783




On Fri, Mar 2, 2018 at 9:49 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Oh wait, patch set 9 worked.

On Fri, Mar 2, 2018 at 9:40 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Thanks guys.

@Roland, I tried all combinations but no luck.

@Mickael, Does this require a CQ for gson and a gerrit for platform releng?

Cheers.

Wim