Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[platform-ui-dev] Adding back TableColumn to CheckBoxTableViewer

CheckBoxTableViewer was changed a few builds ago, to remove the single 
TableColumn it created.
This was done since the TableColumn is not needed by SWT in the case of a 
single column table with headers not visible.
For more details, see http://bugs.eclipse.org/bugs/show_bug.cgi?id=6582.

I am adding this back because it is causing breakage to other clients (in 
addition to Debug which has worked around the problem).
It looks like adding this back may break clients again who adapted to the 
earlier change.
This includes VMPreferencePage and TemplatePreferencePage mentioned in the 
PR above.

I recommend that clients creating a CheckBoxTableViewer who further modify 
the Table by adding columns or making headers visible should create the 
Table widget themselves, rather than relying on the convenience 
constructor in CheckBoxTableViewer.  This will make their code immune to 
this change.

I will hold off until I hear back from the debug team.  If you have any 
concerns with this change, please let me know.

Thanks,
Nick



Back to the top