[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] Bug 509473: Version number of simpleconfigurator goes... down?


----- Original Message -----
> From: "Mykola Nikishov" <mn@xxxxxxxxx>
> To: p2-dev@xxxxxxxxxxx
> Cc: "Markus Keller" <markus_keller@xxxxxxxxxx>
> Sent: Thursday, 19 January, 2017 10:22:28 PM
> Subject: [p2-dev] Bug 509473: Version number of simpleconfigurator goes...	down?
> 
> Hi there,
> 
> I would expect simpleconfigurator's version to go up. Instead, it goes
> down, from 1.2.300.qualifier to 1.2.0.qualifier. Is it OK?

Hi Mykola,
As you can see in http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=6af6e45502dc9325d8fad94f8505a16e5e973590 
minor version was bumped without resetting the micro at 2017-01-10 09:55:32 and it was fixed with the commit you refer to. So considering the very little timespan the error was in I would say it's fine to fix it.

> 
> git show 95a41dc3e -- bundles/org.eclipse.equinox.simpleconfigurator/
> 
>     commit 95a41dc3e542929a2d03e0b9ab8bc1a476ba9101
>     Author: Markus Keller <markus_keller@xxxxxxxxxx>
>     Date:   Tue Jan 10 18:05:08 2017 +0100
> 
>         Bug 509473: Update version number of simpleconfigurator and p2.engine
> 
>     diff --git
>     a/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF
>     b/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF
>     index 7d6e84304..e0ef704c1 100644
>     --- a/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF
>     +++ b/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF
>     @@ -1,7 +1,7 @@
>      Manifest-Version: 1.0
>      Bundle-ManifestVersion: 2
>      Bundle-SymbolicName:
>      org.eclipse.equinox.simpleconfigurator;singleton:=true
>     -Bundle-Version: 1.2.300.qualifier
>     +Bundle-Version: 1.2.0.qualifier
>      Bundle-Name: %bundleName
>      Bundle-Vendor: %providerName
>      Bundle-Localization: plugin
>     diff --git a/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml
>     b/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml
>     index ba165af11..51f218ebc 100644
>     --- a/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml
>     +++ b/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml
>     @@ -9,6 +9,6 @@
>        </parent>
>        <groupId>org.eclipse.equinox</groupId>
>        <artifactId>org.eclipse.equinox.simpleconfigurator</artifactId>
>     -  <version>1.2.300-SNAPSHOT</version>
>     +  <version>1.2.0-SNAPSHOT</version>
>        <packaging>eclipse-plugin</packaging>
>      </project>
> 
> 
> --
> Mykola
> https://manandbytes.github.io/
> 
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/p2-dev
> 

-- 
Alexander Kurtakov
Red Hat Eclipse team