Re: [orbit-dev] Trying out the EBR approach for adding XML RPC 3.1.3 to

[Roland Grunberg <rgrunber@xxxxxxxxxx>]

 > The CQ has been approved very quickly indeed (yippee), and I've done a
> gerrit push.
> (https://git.eclipse.org/r/78687)
> 
> What is the process now?
> 1. Some more experienced Orbit-ers do a review and the merge? Or do I
> need to do some gerrit actions myself?
> 2. How/when would this end-up in a build that results in a stable p2
> repo location that I could then use in my Triquetrum target?
> 
> (apologies for all those questions, but this is my first "in orbit"
> contribution/experience)

No problem. I remember people having plenty of issues in the past
following the old CVS approach, and that one was pretty well documented
so it's understandable to have many questions about this one.

The real bug is that we need to start documenting how the full process
changes using orbit-recipes (eg. from ATO CQ request, to finally
consuming the built repository) as opposed to just individual portions.
The issue is that it's still evolving [1].

I've added myself as reviewer and will look at the change. It mostly
looks fine so I don't see any major issues. I would consider maybe
having a separate module, 'xmlrpc' under 'apache' since you're pushing
multiple bundles part of the same "functionality" and not just one.

Of course if you're absolutely sure you're doing the right thing then you
always have the option to push the change yourself (as was done in the
past in CVS). We might need a discussion about whether we want some policy
regarding pushing (eg. must be reviewed, or not)

Cheers,
-- 
Roland Grunberg

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=484631