Re: [nebula-dev] Dealing with line endings

[Dirk Fauth <dirk.fauth@xxxxxxxxx>]

Here are some additional resources:

http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/
http://schacon.github.io/git/gitattributes.html (important is the section on normalization, as the one in the first link didn't work 100% in NatTable)

I also attach a sample .gitattributes to this mail. This is the one we are using in NatTable.

Although I'm a Nebula committer, I don't want to perform actions that potentially will touch a lot of source files in the whole Nebula project. Maybe Wim will test this first locally?

Greez,
Dirk

On Tue, Dec 10, 2013 at 5:11 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

+1

On Tue, Dec 10, 2013 at 2:08 PM, Dirk Fauth <dirk.fauth@xxxxxxxxx> wrote:

Hi,

I just came across the line ending issues when working with Git where the OS of the committers is not unique.

In [1] is explained that you can handle this by local Git configuration (core.autocrlf) and/or via .gitattributes directly in the repository. Adding the .gitattributes should handle things correctly even if the local Git configuration property is missing. At least I understand it that way.

Wouldn't it make sense then to add such a .gitattributes to Nebula too? Rejecting contributions because of wrong line endings when it can be handled automatically feels wrong.

What do you think?

Greez,

Dirk

[1] https://help.github.com/articles/dealing-with-line-endings

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev

_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev

# Auto detect text files and perform LF normalization
*        		text=auto

# Explicitly declare text files we want to always be normalized and converted 
# to native line endings on checkout.
*.java   		text diff=java
*.html   		text diff=html
*.css    		text
*.js     		text
*.sql    		text
*.properties	text

# Denote all files that are truly binary and should not be modified.
*.png 			binary
*.jpg 			binary