Hi Wayne and others,
Of course we know that attaching the code to the patch means granting
the permission to use the patch (thus the iplog+ flag which will soon
be added to Jerome's patch ;-))
By the way, we've noticed that the copyright banners of the source
files (of the CalendarCombo project at least) may not be 100% IP clean
since there is no file creation/last modification date mentioned (which
I think is important to have a valid copyright; see
http://www.eclipse.org/legal/copyrightandlicensenotice.php)... I think
that would make more sense to use the default Eclipse Foundation banner
in every class in order to be sure everything is OK wrt IP.
Cheers,
Benjamin
Wayne Beaton a écrit :
Just
to clarify...
By creating the bug and posting your patch there, you are implicitly
agreeing to the website terms of use and effectively granting us
explicit permission to use the patch. This keeps our IP clean.
Thank you for taking that extra step for us.
Wayne
Jérôme Combes wrote:
OK. Sorry for bugzilla.
I create the bug 263636 with bugzilla ;).
Tom Schindl a écrit :
Hi Emil,
I think we need a bug report to track the contribution appropiately
else
we are getting in to trouble with IP-Clearance once we do a release! I
highly appreciate the fix from Jérôme but I need to insist on a bug
report!
Thanks for your understanding guys.
Tom Schindl
Nebula CoLead
Emil Crumhorn schrieb:
Hello Jermoe,
Thanks for you bug report and fix (in the future however, please use
Bugzilla for this, as then it can be tracked by others as well). I
will take a look and make the necessary fix in the coming build(s).
Best regards,
Emil
On Wed, Feb 4, 2009 at 2:29 PM, Jérôme Combes
<jerome.combes@xxxxxxxxxxxxxxxx
<mailto:jerome.combes@xxxxxxxxxxxxxxxx>> wrote:
Hello,
I'am using the CalendarCombo widget and I have a bug with it and I
have a solution to correct this problem. (See the attached file).
The bug is the following. If I select in the calendar popup
'Today', then 'None', then 'Today', I have the following exception
(I added a "try ... catch" to see this exception) :
java.lang.StringIndexOutOfBoundsException: String index out of
range: -1
at java.lang.String.<init>(String.java:202)
at org.eclipse.swt.internal.win32.TCHAR.toString(TCHAR.java:115)
at org.eclipse.swt.widgets.Combo.getText(Combo.java:846)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarCombo.setText(CalendarCombo.java:1127)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarCombo.updateDate(CalendarCombo.java:1566)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarCombo.access$20(CalendarCombo.java:1565)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarCombo$17.dateChanged(CalendarCombo.java:1461)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarComposite.notifyListeners(CalendarComposite.java:732)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarComposite.notifyListeners(CalendarComposite.java:745)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarComposite.clickedTodayButton(CalendarComposite.java:214)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarComposite.externalClick(CalendarComposite.java:770)
at
org.eclipse.nebula.widgets.calendarcombo.CalendarCombo$9.handleEvent(CalendarCombo.java:839)
I have this exception because in the class 'CalendarCombo' the
method 'Combo.setText(String )' is used to set the text in the
Combo. I think that the method 'Combo.add(...)' (like in the
method 'CalendarCombosetText(...)') must be always used to set the
text.
In attached file, there is the CalendarCombo with a solution : add
a method 'setComboText(String )' to set the text for the Combo
(flat or not) and I am using only this method in the CalendarCombo
class.
Jérôme
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev
_______________________________________________
nebula-dev mailing list
nebula-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/nebula-dev
</div>
|
