| Re: [mdt-papyrus.dev] Problem with loading custom Properties View context models |
Christian, The following patch fixes the issue. I'm pretty sure the Activator import has changed, but I currently cannot access the SVN history to confirm (SVN is not responding). And of course, I cannot commit it either. This file has been changed on 2012/09/17 (Which means it actually never worked on Kepler). > Does SVN have anything like the extremely handy "git bisect"? I don't know, I never really used git yet. Camille __________________________ Camille Letavernier +33 (0)1 69 08 00 59 - camille.letavernier@xxxxxx CEA LIST - Laboratoire d'Ingénierie dirigée par les modèles pour les Systèmes Embarqués (LISE) Papyrus : http://www.eclipse.org/papyrus -----Message d'origine----- De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de give.a.damus@xxxxxxxxx Envoyé : mardi 12 mars 2013 11:23 À : Papyrus Project list Cc : Papyrus Project list Objet : Re: [mdt-papyrus.dev] Problem with loading custom Properties View context models Thanks, Camille, I've already figured that all out and started to refactor it to factor out pluggable storage of the customization models. You have answered my question: I didn't miss anything. :-) I'm happy to contribute a fix, myself, if it's simply a matter of the models being stored in the wrong plug-in's metadata or being looked for in the wrong plug-in. I can probably even figure out from the history when and why it broke. Does SVN have anything like the extremely handy "git bisect"? cW Sent from my iPhone On 2013-03-12, at 5:32, LETAVERNIER Camille <Camille.LETAVERNIER@xxxxxx> wrote: > Hello Christian, > > > The properties view models can be stored in two different ways: > > - Workspace, in the oep.views.properties metadata folder > - Plug-in, via an extension point > > When a local properties view configuration is being edited, there is a hidden project (oep.customization.properties.internal, IIRC) which is an Eclipse link to the metadata folder. > > I've seen a bug recently, and indeed, the custom properties view > configurations disappears after restarting Eclipse. I cannot access > the SVN history yet, so I can't tell when this regression has been > introduced. The CopyContext action writes the custom properties > configuration to its own metadata folder, instead of the one from > oep.views.properties. (It's really dangerous to have a single class > name for all our Activators :) ) > > I will fix that as soon as the SVN is back online. It's really trivial. > > > Regards, > Camille > __________________________ > Camille Letavernier > +33 (0)1 69 08 00 59 - camille.letavernier@xxxxxx > CEA LIST - Laboratoire d'Ingénierie dirigée par les modèles pour les > Systèmes Embarqués (LISE) Papyrus : http://www.eclipse.org/papyrus > > > -----Message d'origine----- > De : mdt-papyrus.dev-bounces@xxxxxxxxxxx > [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de Christian > W. Damus Envoyé : mardi 12 mars 2013 01:54 À : Papyrus Project list > Objet : [mdt-papyrus.dev] Problem with loading custom Properties View > context models > > Hi, Team, > > Looking at the latest trunk (r10497-ish), I'm confused about how custom Properties View context models are supposed to be loaded. > > I see that the hidden project that the properties view Customization Dialog creates is stored in the workspace metadata directory of the org.eclipse.papyrus.customization.properties plug-in. > > However, the ConfigurationManager class in the org.eclipse.papyrus.views.properties plug-in tries to load the user-defined custom contexts from that plug-in's workspace metadata folder. That obviously won't find the models stored in the other plug-in's metadata. > > Am I missing something? Is something else supposed to inject the custom contexts from the customization plug-in into the ConfigurationManager? It's quite possible that I'm missing a plug-in or working on the wrong version of it. > > Or is this just something that broken in a refactoring when the Properties View plug-in was split up? In any case, I can copy a context and edit it, and see it take effect in the Properties View, but after re-starting the workbench, my custom contexts are all gone. > > I could fix this (for bug 402961) by having the ConfigurationManager load custom contexts from the customization plug-in's metadata directory, but that seems like the wrong direction for that dependency. > > Thanks, > > Christian > _______________________________________________ > mdt-papyrus.dev mailing list > mdt-papyrus.dev@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev > _______________________________________________ > mdt-papyrus.dev mailing list > mdt-papyrus.dev@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev _______________________________________________ mdt-papyrus.dev mailing list mdt-papyrus.dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
Attachment:
properties_custom.patch
Description: properties_custom.patch