[leshan-dev] Data type discrepancy: ResourceModel.Type vs Value.DataType

[Abel de Beer <abel@xxxxxxxxxxxxx>]

Hi all,

I’ve noticed a difference between data type support between org.eclipse.leshan.core.model.ResourceModel and org.eclipse.leshan.core.node.Value:

https://github.com/eclipse/leshan/blob/57e08f581f84b2dd6a9ffac64e12e08837050ea1/leshan-core/src/main/java/org/eclipse/leshan/core/model/ResourceModel.java#L39

Type enum contains: STRING, INTEGER, FLOAT, BOOLEAN, OPAQUE, TIME

https://github.com/eclipse/leshan/blob/57e08f581f84b2dd6a9ffac64e12e08837050ea1/leshan-core/src/main/java/org/eclipse/leshan/core/node/Value.java#L31

DataType enum contains: STRING, INTEGER, LONG, FLOAT, DOUBLE, BOOLEAN, OPAQUE, TIME

Is there a reason for this discrepancy? To me it makes the most sense for both objects to support the same types. If they do, maybe there should be one dedicated type enum to prevent confusion.

Thanks,

Abel de Beer

Cooking Fox 

www.cookingfox.com 

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail