| Re: [leshan-dev] JSON format |
|
Hello, I did the pull request for JSON format implementation 1st version
J. However I got an error message , I think it has went through in GitHub but Eclipse not accepted,
please see the screen shot below:
Thanks, Nizar…!
From: Alseddeg Nizar
Hi Julien, I will go ahead and do the pull request later today’s “ It is not final”. It will be my 1st attempt to make a major contribution in Leshan,
let me know if our code does not meet your conventions and standards, we are very flexible to make any modifications. Regards, Nizar…! From:
leshan-dev-bounces@xxxxxxxxxxx [mailto:leshan-dev-bounces@xxxxxxxxxxx]
On Behalf Of Julien Vermillard Hi Nizar, Sorry for the late reply. Don't hesitate to ask for review of your code even if it's not final (just push it to github). Julien On Thu, Apr 16, 2015 at 5:45 PM Alseddeg Nizar <Nizar.Alseddeg@xxxxxxxxxxx> wrote: Hello Guys, I am working in JSON format, I think I did make a good progress. However, sometimes I
feel I need have some discussions about design extra, as in the new specs they have ObjectLink feature and I don’t think Leshan currently support it. Also the notification about a Resource containing multiple historical representations, Leshan does not support
this feature as well. Both features have been mentioned in JSON format section (6.3.4). Anyway, I can show you what I have done so far ( I have some questions about changing some of the
Leshan core classes, design,..etc), NOT sure is it OK to do this in Leshan Dev group or just make a pull request and somebody will review it.
But, it would be nice to have some discussions about the design / new features, before proceeding
with the pull request? Nizar… This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either
whole or partial, is prohibited. _______________________________________________ This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited. E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender. Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus. |
