Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Flaky tests in the master branch

On Wed, Apr 10, 2024 at 11:44 PM Antonin Delpeuch via jgit-dev <jgit-dev@xxxxxxxxxxx> wrote:
Hi all,

Thanks a lot for your help with my recent patches!

As a follow-up to Martin Lippert's recent message [1] , I confirm that
running
"mvn clean test" on the master branch is also failing for me (Debian
testing, openjdk 17.0.10, Maven 3.8.7, jgit at commit 718d121bb). Some
of the test failures seem to come and go.

Some of the tests (e.g. RacyGitTests) depend on timing which may depend on hardware and OS.
Appreciate any improvement with flaky tests. AFAIK all JGit committers use either MacOS or Linux.
 
Here are some samples of the failures I get:

[ERROR]
MergeToolTest.testEmptyToolName:96->ToolTestCase.runAndCaptureUsingInitRaw:79->ToolTestCase.runAndCaptureUsingInitRaw:112

Expected no standard error output from tool expected:<[compare[:
unrecognized option `-wait' @ error/compare.c/CompareImageCommand/1123.,
compare: unrecognized option `-wait' @
error/compare.c/CompareImageCommand/1123].]> but was:<[compare[-im6.q16:
unrecognized option `-wait' @ error/compare.c/CompareImageCommand/1131.,
compare-im6.q16: unrecognized option `-wait' @
error/compare.c/CompareImageCommand/1131].]>

[ERROR]   RacyGitTests.testRacyGitDetection:57 expected:<...de:100644,
time:t0, [length:1, content:a][b, mode:100644, time:t0, length:1],
content:b]> but was:<...de:100644, time:t0, [smudged, length:0,
content:a][b, mode:100644, time:t0, smudged, length:0], content:b]>

[ERROR]   FileTreeIteratorTest.testDirCacheMatchingId:252
expected:<EQUAL> but was:<SMUDGED>

Here are two successive build logs with different combinations of such
failures:

https://pintoch.ulminfo.fr/6112039b94/jgit_build_log_1.txt

https://pintoch.ulminfo.fr/1bfa4f99be/jgit_build_log_2.txt

What's interesting is that those tests failures are distinct from those
reported by Martin…

It's not a huge deal since I can run individual tests via the IDE but I
guess it'd still be worth having a reliably passing build.

Best wishes,

Antonin

[1]: https://www.eclipse.org/lists/jgit-dev/msg04221.html - I would
reply to in its original thread if I could get hold of the message id

_______________________________________________
jgit-dev mailing list
jgit-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jgit-dev

Back to the top