Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] GC performance change since upgrade to 2.14

On Friday, June 2, 2017 at 3:24:23 AM UTC+1, David Pursehouse wrote:
On Fri, Jun 2, 2017 at 7:33 AM thomasmulhall410 via Repo and Gerrit Discussion <repo-d...@xxxxxxxxxxxxxxxx> wrote:
What if we switched gc off in jgit? Does auto gc still work? That will affect wmf since we switched it off as it broke mediawiki/core.

Can autogc be fixed so that if gc is disabled auto gc is disabled?

Also jgit includes fixes for sha1 collision.

Assuming you mean Shawn's fixes for "SHAttered" [1], those were already in JGit 4.7.0 which is used in Gerrit 2.14.

Aside from the GC fix mentioned by Matthias, the only functional difference in 4.7.1 will be in ManifestParser which is not used by Gerrit.

[2] jgit $ git log --oneline --no-merges v4.7.0.201704051617-r..origin/stable-4.7
f17ec3928 (HEAD -> stable-4.7, origin/stable-4.7) Cleanup and test trailing slash handling in ManifestParser
84d855cda ManifestParser: Throw exception if remote does not have fetch attribute
3db0f507e (origin/stable-4.5, stable-4.5) Prepare 4.5.3-SNAPSHOT builds
c1d3ecbea (tag: v4.5.2.201704071617-r) JGit v4.5.2.201704071617-r
661232b1e PushConnectionTest: Increase maxCommandBytes again
6a311a071 Prepare 4.7.1-SNAPSHOT

On Fri, Jun 2, 2017 at 12:17 PM, thomasmulhall410 via Repo and Gerrit Discussion <repo-discuss@xxxxxxxxxxxxxxxx> wrote:
I was giving a reason on why not rollback the version in jgit

But if auto gc is enabled by default can we add the config in gerrit to disable auto gc please?


please avoid top posting on this list

Can't you set 
gc.auto=0 
gc.autopacklimit=0 
in ~/.gitconfig in order to switch off auto gc globally ?

-Matthias

 

Back to the top