Re: [jgit-dev] gitattributes

[adaussy <arthur.daussy@xxxxxxx>]

Hi,

I did not have any answer to my last email regarding this topic so I went on implementing what I thought to be the correct solution.
I rebased the current patch set on master and I pushed it as a new patch set [0]. I had to change the author of the commit to be able to push it on review since I'm not a JGit commit (I did not know how to do it otherwise).
Then I pushed a second patch set [1] that contains unitary tests and my modifications. The unit tests aim at explaining what my modifications are about. To make it short, I have tried to implement the gitattributes precedence order as it is defined in the gitattribute manual page [2].
In a following review, I will work on a the same feature but for the DirCacheIterator. Depending on the operation (checkout or checkin), we will have to use DirCacheIterator or WorkingTreeIterator as stated in the documentation:

"When the .gitattributes file is missing from the work tree, the path in the index is used as a fall-back. During checkout process, .gitattributes in the index is used and then the file in the working tree is used as a fall-back." from [2]
 
Finally I intend to work on the first high level functionality that uses gitattribute. It could be the "indent" attributes or "eol" attributes depending on the remaining time  I will have to do it.

Is it something that sounds reasonable to you?

[0] https://git.eclipse.org/r/#/c/1614/11/
[1] https://git.eclipse.org/r/#/c/1614/12/
[2] https://www.kernel.org/pub/software/scm/git/docs/gitattributes.html

Le 02/10/2014 09:06, Gunnar Wagenknecht a écrit :

Hi,

Am 01.10.2014 um 23:19 schrieb Matthias Sohn <matthias.sohn@xxxxxxxxx>:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=342372
https://git.eclipse.org/r/#/c/1614/

yes, unfortunately this change stalled, would be nice if someone would find the time to finish it

Actually, the patch is finished. It needs to be rebased on latest master and is then ready to go in. However, it’s only a first step to add the necessary support for reading the attributes. Someone needs to start working on the higher level functionality, eg., line endings or file types.

If that is ok, I can rebase the change and bring it in. But itI needs a +2 from one of the other active/experienced JGit committers.

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx

_______________________________________________
jgit-dev mailing list
jgit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jgit-dev