[jetty-dev] Possible typo in MongoSessionManager

[Denis Bardadym <bardadymchik@xxxxxxxxx>]

Hello.

I am sorry if i wrote to wrong mailing list. I am porting nosql sessions to redis, and while looking sources for mongo, i found:

On line 375 (http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-nosql/src/main/java/org/eclipse/jetty/nosql/mongodb/MongoSessionManager.java#n375)

it traverse by attribute keys that we load from mongo, 

for (String name : attrs.keySet())

then on line 384 (http://git.eclipse.org/c/jetty/org.eclipse.jetty.project.git/tree/jetty-nosql/src/main/java/org/eclipse/jetty/nosql/mongodb/MongoSessionManager.java#n384)

if (attrs.keySet().contains(name))

which inside this cycle always true. It looks like there is a typo, and really should be session.getNames(). I am understand this right?

Thanks, Denis Bardadym