[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ide-dev] Fixing the Target platform editor

FWIW, I share the opinion that adding another layer on top of .target is a layer too much. Yes, there are more fancy alternatives to XML available but that does not necessarily mean we have to add another layer to support them. I too would like to see the issue addresses directly in PDE.

On 22 Nov 2016, at 14:43, Mickael Istria <mistria@xxxxxxxxxx> wrote:

In an ideal world, such improvements would have directly happened in PDE and the .target format and editor...

Keep in mind that it's not just PDE but PDE plus Tycho plus potentially p2. Thus, three different projects would need to be touched (depending on the feature/limitation you want to remove). Three different legacy code based. Three different project teams to communicate with. 

IMO, this is a symptom of our community (and maybe all communities): people try to fix things by creating an upper layer without the limitations rather that fixing what needs to be fixed.

You are making a good point. However, you should know it's by far not as easy as you write it.

As someone who tries fixing things where they should be fixed, let me heat up the discussion:

Even if you go the extra mile and work yourself into an existing, legacy code base - there is simply no guarantee today your change will get in. It is way easier to build something outside of a project - especially outside of PDE. First it was not the right strategy - committers had large visions and particular ideas how to implement things - after you came up with a patch. Then it became lack of resources. Later on it was inexperience with that particular area of the code base.

Frankly, the only one that is really trying is Lars and he admits that he does not know anything about the code base. He was the only one who cares about a patch I submitted to PDE weeks ago. Is this really the strategy?

FWIW, I see Eike has two reviews open with p2. Both opened 2014. No feedback. Nothing. So again, how do you want to motivate people fixing what and where it needs to be fixed?

Crazy idea, what if we just grant commit rights for all project to every member of the AC. I trust every single one of them of doing the right thing. If it's not working out, i.e. bad/poor communication, abuse of power, than they don't belong to the AC.


Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/