[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ide-dev] Development Process

Yes, well, maybe I have missed the latest hot trend. Speaking from my personal experience, it is very hard to do reviews next to my programming job. One of the two suffers, but you are right that it may be a matter of organizing and learning how to do such a thing effectively. Mind you that internally organized reviews (intercompany) are a completely different ballgame compared to the volunteer contributors we have at Eclipse. The latter contributors have their own jobs and will not fit in "fix review comments with x hours" process rules. 

So I am not buying your "need to stop thinking about "Reviewing" and "Coding" as separate activities" just yet although I have to add "in the context of open source contributions".



On Wed, Sep 25, 2013 at 8:43 PM, Miles Parker <miles.parker@xxxxxxxxxxx> wrote:

On 2013-09-25, at 11:13 AM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

> We agree that the "reviewer" must know a lot about the codebase to be productive but I really don't think the two jobs can be done at the same time. It requires a lot of energy to get a large enough patch into the system. It also requires back-and-forth between the contributor and the committer (which can be seen with Gerrit: the committer makes a remark on the code and waits until the contributor responds with a new patch.) This just does not mix with a dedicated programming job.

Hmmm…but this is _exactly_ the way that everyone at Tasktop and Mylyn does their job! (sound good? see sig line below.. ;D ) Also, many much larger software development enterprises -- there were a number of excellent presentations this year at EclipseCon about that. I'm not saying it always makes me happy ;) -- in fact I sort of have a love-hate relationship with it -- but that's how a review oriented dev cultures operate. I'm actually having difficulty understanding how it would work to have some people be "reviewers" and others be the "coders". Seems ripe for all kinds of socio-pathologies. ;D But yes, it's as big a change in mind set as the other agile practices we've adopted over the years like TDD can be. But there is no reason to adopt Gerrit unless you're seeing the world this way.


Miles T. Parker | Tasktop Labs | Tasktop Technologies
email: miles.parker@xxxxxxxxxxx
skype: milestravisparker  | web: http://tasktop.com  | blog: http://milesparker.blogspot.com

Committer: Eclipse Mylyn Reviews, R4E, Virgo
Lead: Eclipse Mylyn MFT, AMP

Are you passionate about innovation and excellence and interested in joining our team? Tasktop, voted one of the Best Companies to Work for in British Columbia, is hiring!

ide-dev mailing list