Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[handly-dev] a few wonderings

Hi!

* SourceConstruct should implement even hashCode to match equals. 

* Why is the class called SourceElementBody and the interface ISourceElementInfo? Wouldn't it be better to keep using a single concept? I'd have preferred to have "body" everywhere, but I can see a point in a different name, as it's not quite the same kind of data as for a source file or project.

* in SourceElement.getelementAt, it's a bit simpler to use
 ISourceElement found =
                getElementAt(children[i], position, base);
as base equals info.getSnapshot() at that place

best regards,
Vlad


Back to the top