| Re: [flux-dev] [flux][che]Adding a new message type |
Hey!
So code-wise you need to add new message types to those files and run the server.
If you would like others to consume and run your version from code, then you can either fork the project and provide your own forked version of it and submit a pull request with those changes.
The prototype wasn’t designed with extensibility in mind, therefore it is not easily possible to add those new message types.
But if you want to, you could change that. For example by having a configuration file that contains all the message types. Then the flux server could read that file and configure the messaging according to that file. Then people could provide their own config file when running the server, for example. I think this would be a much better solution - and an awesome PR… :-)
What do you think?
Cheers,
-Martin
> Am 29.06.2016 um 14:13 schrieb Randika Navagamuwa <randika.12@xxxxxxxxxxxxx>:
>
> Hi Martin,
> Thank you for your reply. Does that mean that new message type should be added to the Flux codebase? To do that, I have to add that new broadcast configs to relevant files and send a PR? Please correct me if I'm wrong.
> Thanks,
>
> On 29 June 2016 at 17:12, Martin Lippert <mlippert@xxxxxxxxx> wrote:
> Hey Randika,
>
> you are right, you need to add the new message type to messages-core.js and rabbit-connector.js to get the broadcast configured for them.
> Otherwise those messages would not be broadcasted to all the connected clients.
>
> Cheers,
> -Martin
>
>
> > Am 27.06.2016 um 18:15 schrieb Randika Navagamuwa <randika.12@xxxxxxxxxxxxx>:
> >
> > Hi all,
> > I'm working on a GSOC project[1] related to Eclipse che. Basic idea of the project is to display cursors of all the participants of the pair programming session. I'm using liveResourceChanged message type to pass the message when there is a change in the document. I thought of adding a new message type called liveCursorOffsetChanged, to pass the message when there is only a cursor movement change. Is it okay to add this into rabbit-connector.js and messages-core.js classes or is there a better way to do this?
> >
> > [1]https://summerofcode.withgoogle.com/projects/#4522349613285376
> >
> > --
> > Best Regards
> > Randika Navagamuwa,
> > Department of Computer Science & Engineering,
> > University of Moratuwa,
> > Sri Lanka.
> > www.rnavagamuwa.com
> >
> > _______________________________________________
> > flux-dev mailing list
> > flux-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/flux-dev
>
> _______________________________________________
> flux-dev mailing list
> flux-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/flux-dev
>
>
>
> --
> Best Regards
> Randika Navagamuwa,
> Department of Computer Science & Engineering,
> University of Moratuwa,
> Sri Lanka.
> www.rnavagamuwa.com
>
> _______________________________________________
> flux-dev mailing list
> flux-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/flux-dev
_______________________________________________
flux-dev mailing list
flux-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/flux-dev