Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Commit Validation

To make more clear what I'm trying to achieve, here is a mockup of the result I expect from a users point of view (the messages are completely made up, of course ;)):

 

 

From a developers point of view, I’d like this to be really easy to use. All the information should be easy to grab, and there should be (if possible) not multiple ways of implementing validation.

 

Do you think we can come up with a solution that fits?

 

Cheers,

Markus

 

> -----Ursprüngliche Nachricht-----

> Von: Halstrick, Christian [mailto:christian.halstrick@xxxxxxx]

> Gesendet: Montag, 9. März 2015 11:38

> An: Andrey Loskutov; Duft Markus

> Cc: EGit developer discussion (egit-dev@xxxxxxxxxxx)

> Betreff: RE: [egit-dev] Commit Validation

>

> I also think that we should try to use hooks for this purpose. Validating commits is a very common use case for hooks and

> many people write scripted hooks to achieve that. As Andrey also mentioned let's not invent another way to achieve that.

> On the other hand I understand why you want to avoid scripting. But since we already have a way how we call external

> scripts it should be not so hard to call Java instead.  See [1], [2]. Having a subclass of GitHook which calls Java instead of

> external processes in doRun() should be easy, or? Just as a proof of concept one could start trying this. But of course more

> work is coming then (how to register, to to deploy hooks to installed IDEs (you have your own build of E/JGit, right?). But I

> guess it's less work than creating a new thing like validators separate from hooks.

>

> [1] https://github.com/eclipse/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/api/CommitCommand.java#L178

> [2] https://github.com/eclipse/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/hooks/GitHook.java#L147-L157

>

 

Salomon Automation GmbH | Friesachstrasse 15 | 8114 Friesach bei Graz | Austria
Registered Office: Friesach bei Graz | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz

Back to the top