Re: [ecf-dev] NullpointerException in RemoteServiceAdmin

[Scott Lewis <slewis@xxxxxxxxxxxxx>]

Hi Peter,

I believe this is due to the (incorrect) line in ImportRegistration.close():

        public void close() {
            boolean publish = false;
            ID containerID = null;
            Throwable exception = null;
            EndpointDescription endpointDescription = null;
            ImportReference imRef = null;
            synchronized (this) {
                // only do this once
                if (!closed) {
                    containerID = getContainerID();
                    exception = getException();
                    endpointDescription = getEndpointDescription();
                    imRef = this.importReference;
                    publish = importReference.close(this);
                    this.importReference = 
null;                             <-- this line should be deleted
                    closed = true;
                }
            }
...more code

I believe the importReference should never be set to null in the 
ImportRegistration and that it is incorrect that it did so.   Also 
synchronization needs to be added to ImportRegistration accessors so 
that the synchronized block above prevents access to importReference 
before closed = true (which is resulting in NPE I think).

Peter if you would please open a bug, and put your info in comments I 
will address in latest version as soon as I can.

Scott





On 9/18/2018 7:33 AM, Peter Hermsdorf wrote:
> Hi,
>
> we sometimes faces the following error:
>
> java.lang.NullPointerException
>     at 
> org.eclipse.ecf.osgi.services.remoteserviceadmin.RemoteServiceAdmin$ImportRegistration.getException(RemoteServiceAdmin.java:1139)
>     at 
> org.eclipse.ecf.osgi.services.remoteserviceadmin.RemoteServiceAdmin$ImportRegistration.getImportReference(RemoteServiceAdmin.java:1104)
>     at 
> org.eclipse.ecf.osgi.services.remoteserviceadmin.RemoteServiceAdmin.getImportedEndpoints(RemoteServiceAdmin.java:519)
>
> The corresponding code in the class ImportRegistration is
>
> public Throwable getException() {
>             return 
> (closed)?updateException:importReference.getException();
> }
>
> So obviously importReference is null but closed is false.
>
> Any ideas what could cause this state? I've seen that there are 
> changes on this class but wasn't able to determine if these have 
> something to do with this handling.
>
> We are still on ECF version 3.13.8 and we are using the ecf-genric 
> provider.
>
> The above code and the call to getImportedEndpoints is used to update 
> the connection state in an RCP application and is asynchronously 
> executed and triggered by a new event to an RemoteServiceAdminListener 
> .... so more ore less on service state change.
>
>
> Any hints are welcome!
>
>
> Thanks, bye Peter
>
>
> _______________________________________________
> ecf-dev mailing list
> ecf-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ecf-dev