[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] Issue adding custom serialization to ecf provider

Hi Scott,


Am 30.06.2017 um 19:19 schrieb Scott Lewis:

Yes it would be better, but it would mean a breaking API change unfortunately.

I've reopened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=516074

made the addition, and pushed to master.ÂÂ Our hipp instance appears to me to be down right now, but once it comes up there will be a build available that includes this change.ÂÂ I can/will do a maintenance release to include it, but the question is when?
Thanks again.

Regarding the contribution of a bundle with a Kryo serializer and an example:

* where to contribute?
* open a bug and create a gerrit change request or should i start something on my github repo and that might be moved to the ECF repo when reuqired?
* I would modify one the existing "hello" or timeservice examples, ok? (i remeber that one of them already had code which uses an ISharedObjectContainer which I also need to register the serializer)

I've created a separate bundle for the de-/serializer which uses the DynamicImport-Package directive in the manifest - works as expected. The other stuff regarding "handling different package version" was not obvious enough for me to integrate in the first shot - maybe you or someone else can add / modify that later ...

Bye, Peter