[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] Issue adding custom serialization to ecf provider

On 6/29/2017 10:57 PM, Peter Hermsdorf wrote:

Hi Scott,

you are right. I mixed up the two classes.

The fix is in

org.eclipse.ecf.remoteservice.RemoteServiceRegistrationImpl.Properties

and now I need the same fix (for the same reason) in

org.eclipse.ecf.provider.remoteservice.generic.RemoteServiceRegistrationImpl.Properties

Thanks in advance.

Bonus Question: wouldn't it be better to extract the Property class somewhere? The code seems to be identical....

Yes it would be better, but it would mean a breaking API change unfortunately.

I've reopened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=516074

made the addition, and pushed to master.ÂÂ Our hipp instance appears to me to be down right now, but once it comes up there will be a build available that includes this change.ÂÂ I can/will do a maintenance release to include it, but the question is when?

Thanks,

Scott



Bye, Peter

Am 30.06.2017 um 05:20 schrieb Scott Lewis:
Hi Peter,

This was the bug I think:Â https://bugs.eclipse.org/bugs/show_bug.cgi?id=516074 and the fix was in the org.eclipse.ecf.remoteservice bundle.ÂÂ Here's the commit:

http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/commit/?id=eca72faf45ea5dc5dea36991881ddeb3e4e0aeb0

And that bundle was updated after the fix:Â org.eclipse.ecf.remoteservice_8.12.0.v20170503-0247.jar

If this isn't right please let me know.

Scott


_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ecf-dev

Âre