Re: [ecf-dev] Issue adding custom serialization to ecf provider

[Peter Hermsdorf <peter.hermsdorf@xxxxxxxxx>]

Hi Scott,

you are right. I mixed up the two classes.

The fix is in

org.eclipse.ecf.remoteservice.RemoteServiceRegistrationImpl.Properties

and now I need the same fix (for the same reason) in

org.eclipse.ecf.provider.remoteservice.generic.RemoteServiceRegistrationImpl.Properties

Thanks in advance.

Bonus Question: wouldn't it be better to extract the Property class somewhere? The code seems to be identical....

Bye, Peter

Am 30.06.2017 um 05:20 schrieb Scott Lewis:

Hi Peter,

This was the bug I think:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=516074 and the fix was in the org.eclipse.ecf.remoteservice bundle.   Here's the commit:

http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/commit/?id=eca72faf45ea5dc5dea36991881ddeb3e4e0aeb0

And that bundle was updated after the fix:  org.eclipse.ecf.remoteservice_8.12.0.v20170503-0247.jar

If this isn't right please let me know.

Scott