Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Building SimRel with Tycho for 2021-03

> Fix version will fix the version of the features in category.xml
> according to p2 repos. Eg for each feature in category.xml, it would
> verify the feature for the given version is available in the p2 repos
> (target platform), and if not, it would suggest a change to make.

So it does not really fix anything in the file itself? I could then think about an addition to tycho that might be useful in general as well:

Currently, if tycho can't resolve it simply fails with: "can't resolve because missing requirement XYZ and so on"

It would be really useful (and might solve the issue for simrel also) if we can add some pice of code that emits if there is an alternative version or no version at all for the missing requirement, eclipse (or P2?) even computes "alternative solutions", maybe this feature can be reused to give the required hints.

The the simrel validation will fail with a message suggesting the right versions to use in category.xml


Am 11.11.20 um 09:29 schrieb Mickael Istria:


On Wed, Nov 11, 2020 at 9:00 AM Christoph Läubrich <laeubi@xxxxxxxxxxxxxx <mailto:laeubi@xxxxxxxxxxxxxx>> wrote:

    As I'm currently working on category.xml adding support for source
    features/bundles if someone can explain what exactly this "fix
    versions"
    does I can investigate if it is possible to be added to tycho.


Fix version will fix the version of the features in category.xml according to p2 repos. Eg for each feature in category.xml, it would verify the feature for the given version is available in the p2 repos (target platform), and if not, it would suggest a change to make. This is similar and a slight variation of https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FixVersionsMojo.java <https://github.com/jbosstools/jbosstools-maven-plugins/blob/master/tycho-plugins/target-platform-utils/src/main/java/org/jboss/tools/tycho/targets/FixVersionsMojo.java> which enables some similar feature for .target file (however it also replaced 0.0.0, which is not desired here); so it's technically totally doable.

    Tycho has already a version-updater for bundles/features so one for
    category.xml seems valid for me.


It's a bit different, as it's about fixing the content of the file. Not sure we're talking about the same thing here.

    Another area I'm currently investigating is creating an update-site of
    everything in the current reactor build so category.xml is generated
    automatically, not sure if this is applicable/useful for simrel as well.


Nope, SimRel just takes as input the p2 repos and a category.xml to create a new p2 repo aggregating content. There is nothing else built in the same reactor.

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev



Back to the top