[cross-project-issues-dev] BIRT birt.aggrcon git commit for 2019-06

[Mihail Mihaylov <mmihaylo@xxxxxxxxxxxx>]

Eclipse Community,

 

We will need your help completing the BIRT birt.aggrcon git commit for 2019-06.

 

Pls advise who may be able to help our build engineers get this done.

 

Captured in the thread below is the issue: our birt.aggrcon git commit for 2019-06 is being held up in code review, and it failed in a simrel CI build:

https://git.eclipse.org/r/#/c/141998/;  https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/542/

 

Please advise what to do

Thx

Mihail

 

 

From: Rob Petti
Sent: Friday, May 10, 2019 3:46 PM
To: David Wink <dwink@xxxxxxxxxxxx>; Juan Fernandez <juanf@xxxxxxxxxxxx>
Cc: Mihail Mihaylov <mmihaylo@xxxxxxxxxxxx>; Yulin Wang <wangy@xxxxxxxxxxxx>; Ritesh Motlani <rmotlani@xxxxxxxxxxxx>; Galina Derenshteyn <gderensh@xxxxxxxxxxxx>; John Ward <jward@xxxxxxxxxxxx>
Subject: RE: BIRT birt.aggrcon git commit for 2019-06

 

That was my assumption as well, but the diff looks fine:

 

From: David Wink
Sent: Friday, May 10, 2019 16:35
To: Juan Fernandez <juanf@xxxxxxxxxxxx>
Cc: Mihail Mihaylov <mmihaylo@xxxxxxxxxxxx>; Yulin Wang <wangy@xxxxxxxxxxxx>; Ritesh Motlani <rmotlani@xxxxxxxxxxxx>; Galina Derenshteyn <gderensh@xxxxxxxxxxxx>; John Ward <jward@xxxxxxxxxxxx>; Rob Petti <rpetti@xxxxxxxxxxxx>
Subject: Re: BIRT birt.aggrcon git commit for 2019-06

 

Looking at the logs looks like something in or around the emails is wrong 

Thanks

Dave

On May 10, 2019, at 5:19 PM, Juan Fernandez <juanf@xxxxxxxxxxxx> wrote:

Good news/bad news…

 

Good news: we were able to push through the commit.

 

Bad news: it is being held up in code review, and it failed in a simrel CI build:

 

Code review

https://git.eclipse.org/r/#/c/141998/

 

CI build

https://ci.eclipse.org/simrel/job/simrel.runaggregator.VALIDATE.gerrit/542/

 

 

Not sure how to move forward from here.

 

/J

 

 

On May 10, 2019, at 3:41 PM, Juan Fernandez <juanf@xxxxxxxxxxxx> wrote:

 

Hey guys, looks like I'm still missing something, as I was not able to commit:

 

juanf@JUANFPF165GMK:~/repos/org.eclipse.simrel.build$ git push review

Counting objects: 3, done.

Compressing objects: 100% (3/3), done.

Writing objects: 100% (3/3), 386 bytes | 386.00 KiB/s, done.

Total 3 (delta 2), reused 0 (delta 0)

remote: Resolving deltas: 100% (2/2)

remote: Processing changes: refs: 1, done

remote: ----------

remote: Reviewing commit: 57a1ddce

remote: Authored by: Juan Fernandez <juanf@xxxxxxxxxxxx>

remote:

remote: The author is not a committer on the project.

remote: The author has a current Eclipse Contributor Agreement (ECA) on file.

remote: error: The author has not "signed-off" on the contribution.

remote: If there are multiple commits, please ensure that each commit is signed-off.

remote: Please see http://wiki.eclipse.org/ECA

To ssh://git.eclipse.org:29418/simrel/org.eclipse.simrel.build.git

 ! [remote rejected]   HEAD -> refs/for/master (The contributor must "sign-off" on the contribution.)

error: failed to push some refs to 'ssh://jfernandezird@xxxxxxxxxxxxxxx:29418/simrel/org.eclipse.simrel.build.git'

 

...changing user to Eclipse ID

 

juanf@JUANFPF165GMK:~/repos/org.eclipse.simrel.build$ git push

Counting objects: 3, done.

Compressing objects: 100% (3/3), done.

Writing objects: 100% (3/3), 386 bytes | 386.00 KiB/s, done.

Total 3 (delta 2), reused 0 (delta 0)

remote: Resolving deltas: 100% (2/2)

remote: Branch refs/heads/master:

remote: You are not allowed to perform this operation.

remote: To push into this reference you need 'Push' rights.

remote: User: jfernandezird

remote: Please read the documentation and contact an administrator

remote: if you feel the configuration is incorrect

remote: Processing changes: refs: 1, done

To ssh://git.eclipse.org:29418/simrel/org.eclipse.simrel.build.git

 ! [remote rejected]   master -> master (prohibited by Gerrit: ref update access denied)

error: failed to push some refs to 'ssh://jfernandezird@xxxxxxxxxxxxxxx:29418/simrel/org.eclipse.simrel.build.git'

juanf@JUANFPF165GMK:~/repos/org.eclipse.simrel.build$

 

 

Yulin, I hope you have all the right privileges to complete this.

 

Best.

/J