[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Fw: Xtext is broken in Oxygen 1a



On Sat, Oct 7, 2017 at 10:22 AM, Sven Efftinge <sven.efftinge@xxxxxxxxxx> wrote:
Yes, but there are still usages of internal API somewhere in the code base. We want to reduce that [1] but this is not something we can do shortly. Maybe it is not even possible at all.

If not possible at all now you have to engage with JDT team by opening bug describing what you need and maybe even come up with patch to expose it as API from JDT. With the ever increasing cadence and limited resources this is the only way to achieve stability in the release train. If dependent projects just use internals without getting in contact with their dependency to get what they need exposed as API these breakages are inevitable. Internal packages are internal for a reason and there is no way to know that someone is using your internals if there isn't at least a bz describing what/why/how.
FWIW, to encourage people to engage with the project in Linux Tools project we intentionally removed internal packages from export package list so the only viable path becomes exposing API.Â
Â
In the past we had builds that would run against all different versions (incl. the latest head) so we would get informed when we get broken. We stopped doing that due to high maintenance effort. But maybe we should reconsider that [2].


2017-10-06 18:06 GMT+02:00 Aleksandar Kurtakov <akurtako@xxxxxxxxxx>:


On Fri, Oct 6, 2017 at 5:47 PM, Sven Efftinge <sven.efftinge@xxxxxxxxxx> wrote:
Thanks! We removed that usage already on HEAD. It is going to be released on October 20.

Did you achieve that without using internals?
Â

2017-10-06 15:56 GMT+02:00 Mike Wilson <Mike_Wilson@xxxxxxxxxx>:

I agree with Alex's assessment of the perils of using internals. Given the seriousness of this problem, I would suggest we do a respin anyway, and would argue we should fix the internal signature at the same time. In return, the XText team should commit to getting off the use of that method asap, with our help to add missing (actual) API as needed.

McQ.

Inactive hide details for "Daniel Megert" ---2017/10/06 08:42:19---In case of a respin we would definitely include that fix. Da"Daniel Megert" ---2017/10/06 08:42:19---In case of a respin we would definitely include that fix. Dani

From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
To: Cross project issues <cross-project-issues-dev@eclipse.org>
Cc: cross-project-issues-dev-bounces@xxxxxxxxxxx, "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Date: 2017/10/06 08:42
Subject: Re: [cross-project-issues-dev] Fw: Xtext is broken in Oxygen 1a
Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx





In case of a respin we would definitely include that fix.

Dani




From:
Fred Bricon <fbricon@xxxxxxxxx>

To:
Cross project issues <cross-project-issues-dev@eclipse.org>

Cc:
"eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Date:
06.10.2017 14:30

Subject:
Re: [cross-project-issues-dev] Fw: Xtext is broken in Oxygen 1a

Sent by:
cross-project-issues-dev-bounces@xxxxxxxxxxx




While we're on the subject of respinning RC2, JDT has a critical bug[1] that prevents any project with multiple output folders (Maven, Gradle) from running any class (be it main or test) from the IDE, with Java 9.
A simple fix[2] was committed yesterday in master, I strongly believe this should be backported to Oxygen.1a, given that, most likely, all new greenfield Java 9 projects will use a build tool affected by that bug.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=525382
[2] http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=75be8bb1ddb3552d9791b112774fdc3dee352590


On Fri, Oct 6, 2017 at 8:24 AM, Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:
On Fri, Oct 6, 2017 at 3:15 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
> Dear Eclipse PMC
>
> Should we consider to bring back the internal method and ask for a respin?
> We could provide a fix earlier than Wednesday, but it can also be risky to
> respin the Platform/JDT at this point,.

While the "practical me" would say "Yes, if JDT team feels comfortable
with that", I'm leaning towards -1 for this one because it practically
means treating internals as API thus encouraging people to use them
directly instead of working close with projects they depend on to make
APIs stronger and more feature full.
I would +1 a case where the method is bringed back in Oxygen only for
the sake of preserving some compatibility.

>
> Dani
>
> ----- Forwarded by Daniel Megert/Zurich/IBM on 06.10.2017 14:11 -----
>
> From: Sven Efftinge <sven.efftinge@xxxxxxxxxx>
> To: Cross project issues <cross-project-issues-dev@eclipse.org>
> Date: 06.10.2017 13:59
> Subject: [cross-project-issues-dev] Xtext is broken in Oxygen 1a
> Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> Hi all,
>
> Xtext is broken in Oxygen 1a, due to a signature change in an internal API
> of JDT [1][2]. It is a real blocker for Xtext and any downstream projects.
> Xtext will release a new version 2.13 with a fix on October 20.
>
> We could also create a bugfix release for Oxygen 1a, given we decide this is
> important enough to do a respin. We could provide it by Wednesday.
>
> Regards,
> Sven
>
> [1] - https://github.com/eclipse/xtext-eclipse/issues/393
> [2] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=525462
>
> --
> Sven Efftinge
>
> TypeFox GmbH
> Am Germaniahafen 1
> 24143 Kiel
>
> Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
> Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan
> KÃhnlein_______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cross-2Dproject-2Dissues-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=_xjYWLkqX6J0VN-uMpnmC15-iZH4bZE-uyC5O4uesB8&s=Bf6rr6RlsSxmzemmUU16GsrmA2iVPB9YIxwpcX0JnFs&e=
>
>
> _______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
"Have you tried turning it off and on again" - The IT Crowd
And if that fails, then http://goo.gl/tnBgH5_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cross-2Dproject-2Dissues-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=DX_5WHLyEn5O4R4MElNkyzIG1lxueoaNUqkNjf8ZBBo&s=1uXwAYojQVdv_4CWrXgu5AoXzg3D6COx3lN8BYBaCV4&e=

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_cross-2Dproject-2Dissues-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=_wIUljAJCs0TNguPJokfIu7BolLXG8H-Me7DQihCrZ0&m=tm_UOhBI6FkctSpJgo1yPVgn3zH9-UJNiRmWRRoN8GE&s=rZiZi4HABmBHlZIxV3iC1eHcVGsA4Znx_2IaQxd20Nw&e=Â



_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
Sven Efftinge

TypeFox GmbH
Am Germaniahafen 1
24143 Kiel

Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan KÃhnlein

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
Alexander Kurtakov
Red Hat Eclipse Team

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
Sven Efftinge

TypeFox GmbH
Am Germaniahafen 1
24143 Kiel

Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan KÃhnlein

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



--
Alexander Kurtakov
Red Hat Eclipse Team