[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] i18n Message key generation

I could give you counter examples. The main reason for your examples is history. There is no reason for plain text keys. Our tooling shows the value and offers hyperlinking. Short keys are good. You'd have to find a JDT committer that would accept your change - it won't be me ;-)

Dani



From:        Wim Jongman <wim.jongman@xxxxxxxxx>
To:        Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date:        06.02.2017 13:21
Subject:        Re: [cross-project-issues-dev] i18n Message key generation
Sent by:        cross-project-issues-dev-bounces@xxxxxxxxxxx





> If not, would you consider accepting a contribution that adds some
> additional logic to the key generation?


Yes, no, and no.


Okay let me try better:

Assuming that no one [1] will leave in the generated key name (i.e. Class_0 Class_1 Class_2), I think it would be nice to help people and allow to generate a more meaningful key instead.

If adding long keys is a problem, a key generation algo could help:

* When large keys are generated, the dialog can inform the user about memory and speed implications.
* A key generator could help minimize the key length. Consider this key from jface:

MessageDialogWithToggle.rememberMyDecision = &Remember my decision
could be automatically generated to:
    MessageDialogWithToggle.rememberDecision = &Remember my decision
   MssgDlgWTggl.rememberDecision = &Remember my decision
or even
   MDWT.rememberDecision = &Remember my decision


Cheers,

Wim


[1] Random pick of messages.properties

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/messages.properties
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/messages.properties
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.jface/src/org/eclipse/jface/messages.properties
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev