Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] When are Gerrit commits automatically applied?

There are really two scenarios for using Gerrit - at least for me:

1) I know I want to commit that fix but want it to be verified by Hudson first.
2) I or a contributor uploads some code for a "real" review by another committer. In that case it would be very bad if the change got merged after only Hudson is happy.

Dani



From:        "Konstantin Komissarchik" <konstantin.komissarchik@xxxxxxxxxx>
To:        "'Cross project issues'" <cross-project-issues-dev@xxxxxxxxxxx>
Date:        21.05.2015 00:36
Subject:        Re: [cross-project-issues-dev] When are Gerrit commits        automatically applied?
Sent by:        cross-project-issues-dev-bounces@xxxxxxxxxxx




What's the value in encouraging the developer to wait until verification is
done? Either, it's critical that the contribution goes in, in which case the
developer will wait anyway, or it's not critical and any failures can be
dealt with tomorrow.

- Konstantin

PS: Personally, I'd like to see gerrit/hudson style automated verification
combined with bullet-proof aggregation process that is not susceptible to
contributed repositories changing from underneath it.


-----Original Message-----
From: cross-project-issues-dev-bounces@xxxxxxxxxxx
[
mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Stephan
Herrmann
Sent: Wednesday, May 20, 2015 3:23 PM
To: cross-project-issues-dev@xxxxxxxxxxx
Subject: Re: [cross-project-issues-dev] When are Gerrit commits
automatically applied?

On 05/21/2015 12:11 AM, Konstantin Komissarchik wrote:
> [...] but once that
> verification has been done, what's the value of waiting for the
> developer to click on things?

Maybe "encouraging" the developer to wait until s/he knows whether the job
is done or not?
:)

Disclaimer: as much as I like gerrit, for simrel contributions I still
prefer running the validation "at home" and then push directly ..
Call me I'm old-school, if you like.

Stephan

> -----Original Message-----
> From: cross-project-issues-dev-bounces@xxxxxxxxxxx
> [
mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of
> Stephan Herrmann
> Sent: Wednesday, May 20, 2015 2:42 PM
> To: cross-project-issues-dev@xxxxxxxxxxx
> Subject: Re: [cross-project-issues-dev] When are Gerrit commits
> automatically applied?
>
> I'm not sure what's the goal here?
> Enable submit-to-gerrit-and-leave -
> without awaiting the result from hudson? ;P If you wait for success,
> what harm is done by having to do two more clicks?
>
> my 2c.
> Stephan
>
> On 05/20/2015 07:44 AM, Eike Stepper wrote:
>> Hi,
>>
>> I'm not a Gerrit expert, but a quick search for "gerrit auto approve"
> gives a number of hints, for example a Gerrit hook script:
>>
http://renier.morales-rodriguez.net/post/49144483266/configuring-gerr
>> i
>> t-to-auto-submit-on-patch-ap
>>
>> Personally I'd also like it if my simrel patch sets would be
>> submitted automatically if Hudson gives a +1, but I'm not sure if
>> that's a security
> concern.
>>
>> Cheers
>> /Eike
>>
>> ----
>>
http://www.esc-net.de
>>
http://thegordian.blogspot.com
>>
http://twitter.com/eikestepper
>>
>>
>>
>> Am 18.05.2015 um 19:24 schrieb Mickael Istria:
>>> On 05/18/2015 06:43 PM, David M Williams wrote:
>>>> I don't know the answer to Sven's question ... quoted here ... does
> anyone else?
>>>>
>>>>> Am I right if committer of the org.eclipse.simrel.build Git repo
>>>>> must be manually set them as code reviewer if they want to apply
>>>>> the patch to the Git repo? I've hoped that the push is
>>>>> automatically done if the Hudson build is successful and a fast
> forward merge is possible.
>>>>
>>>> I would hope that it would be applied automatically ... but, from
>>>> my experience it doesn't seem to be. But, I've only done it a few
>>>> times, and hope a more Gerrit knowledgeable person can answer
>>>> authoritatively ... as well as make sure the "right thing" happens,
>>>> if
> it takes a new bug for webmasters or others to change some setting.
>>> Gerrit requires a manual approval from a Simrel committer to merge a
>>> commit. There is no mechanism to automatically merge a review if
>>> automated tests have succeeded; and since I believe the paradigm of
> Gerrit and code-review is really to involve an additional human step
> (in best case a 3rd-party) in the change, automating merge is probably
> not something desirable.
>>> However, as a committer, you can apply your own patch via Gerrit UI,
>>> or
> push without using a Gerrit review (and automated tests).
>>>
https://wiki.eclipse.org/index.php?title=Simrel/Contributing_to_Simr
>>> e l_Aggregation_Build#Pushing_your_changes
>>>
>>> HTH
>>> --
>>> Mickael Istria
>>> Eclipse developer at JBoss, by Red Hat <
http://www.jboss.org/tools>
>>> My blog <
http://mickaelistria.wordpress.com> - My Tweets
>>> <
http://twitter.com/mickaelistria>
>>>
>>>
>>> _______________________________________________
>>> cross-project-issues-dev mailing list
>>> cross-project-issues-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or
>>> unsubscribe from this list, visit
>>>
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>>
>>
>> _______________________________________________
>> cross-project-issues-dev mailing list
>> cross-project-issues-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>>
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>
> _______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
>
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>
> _______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
>
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev



Back to the top