Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Xtext RC4

Ed, 

comments inline

On Jun 12, 2013, at 11:47 AM, Ed Willink <ed@xxxxxxxxxxxxx> wrote:
Doesn't it need PMC approvals before being resolved as fixed?

No, we don't follow that policy anymore.

From the yet to be superseded http://wiki.eclipse.org/Modeling_Project_Ramp_Down_Policy/Helios
  • After RC3: Two additional Committers and at least 2 PMC members must review and vote +1 after reviewing the bug for appropriateness and risk.
Two additional committers have reviewed the change.
I don't see why votes from the PMC would help.

After reviewing the commit myself, I see quite a lot of new lines and control flow changes in core code, but the bug description reads as a UI inelegance rather than a killer. So IMHO not really appropriate for RC4.

It's an important missing compiler analysis. I don't think UI is mentioned at all.

Regards,
Sven

Back to the top