Re: [cross-project-issues-dev] [keplerAggregation] Failed for build 2012

[Igor Fedorenko <ifedorenko@xxxxxxxxxxxx>]

I tracked the problem to p2 JarProcessor, which actually tempers with
eclipse.inf.

m2e bundles have eclipse.inf files that look like

   #Sun Aug 19 07:19:44 EDT 2012
   pack200.conditioned=true

but eclipse.inf 'adjusted' by JarProcessor look like

   #Processed using Jarprocessor
   pack200.conditioned = true

There is also TODO in JarProcessor.java around like 314 which appears relevant

   //TODO: This is not strictly necessary if we didn't change the inf
file and didn't change any content

As far as I can tell this is a bug in p2 JarProcessor, it performs
some unneeded processing of m2e bundles and invalidates jar file
signature while doing that.

--
Regards,
Igor

On Sun, Aug 19, 2012 at 9:50 AM, Igor Fedorenko <ifedorenko@xxxxxxxxxxxx> wrote:
> Agrregator build still fails so I disabled m2e contribution.
>
> --
> Regards,
> Igor
>
> On Sun, Aug 19, 2012 at 9:20 AM, Igor Fedorenko <ifedorenko@xxxxxxxxxxxx> wrote:
>> I rebuilt everything using java6 and published new 1.2.0.20120819-1116
>> repo. I also removed all previous m2e 1.2 repos to avoid any possible
>> confusion.
>>
>> I am able to validate all pack.gz files in the new repo using jarsigner
>> tool.
>>
>> I am able to do "Clean Then Build Aggregation" successfully from b3
>> aggregator ui 0.2.0.v20111124-1601 locally using (Apple) java6, although
>> I am not sure if this validates pack200 files. I did enable m2e before
>> testing ;-) I will disable m2e if aggregator still fails.
>>
>> I am open for ideas what else I can check or change.
>>
>> --
>> Regards,
>> Igor
>>
>>
>> On 12-08-19 12:38 AM, David M Williams wrote:
>>>
>>> It looks right to me too using unpack200 and jarsigner -verify.
>>>
>>> That is, your directory 1.2.0.20120818-2030 looks ok, but your repo at
>>> 1.2.0.20120818-0226 shows the "verify" errors we saw and talked about
>>> earlier in the day. So, I do think you are simply hitting a new bug.
>>>
>>> But, your 1.2.0.20120818-2030 repo fails for me too (even pointing
>>> directly at it, so I know it is not a composite issue). And, if fails
>>> whether I use Java 6 or Java 7 (to "read") the repo.
>>>
>>> With what version did you write it? Java 7 by any chance? And are the
>>> jars that are failing nested bundles/jars?
>>> If so, I am wondering if you are running into the "reverse" of bug 361628.
>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=361628
>>>
>>> I say reverse since bug 361628 is about reading packed nested jars with
>>> Java 7 ... but ... maybe something similar happens when writing with
>>> Java 7, and not sure too many people have done that?
>>> (We do, BTW, use Java 6 to run the aggregator, so I know that the Java 7
>>> issue is not in play there, when we read it).
>>>
>>> I see it is not failing for all your jars, so, if it  it is only on the
>>> nested jars it is failing, you might try writing them with Java 6 as a
>>> test? And/or, seems the general advise from bug 361628 is to set
>>> jarprocessor.exclude.children=true
>>> in your ellipse.inf file.
>>>
>>> HTH
>>>
>>>
>>>
>>>
>>>
>>> From: Igor Fedorenko <ifedorenko@xxxxxxxxxxxx>
>>> To: David M Williams/Raleigh/IBM@IBMUS, Cross project issues
>>> <cross-project-issues-dev@xxxxxxxxxxx>,
>>> Date: 08/18/2012 11:16 PM
>>> Subject: Re: [cross-project-issues-dev] [keplerAggregation] Failed for
>>> build        2012-08-18_16-50-43
>>> Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx
>>> ------------------------------------------------------------------------
>>>
>>>
>>>
>>>
>>> I will need some help with this. I verified that both jar and pack.gz
>>> files in m2e repository are correctly signed and pass "jarsigner
>>> -verify" test. I also verified that changing META-INF/eclipse.inf makes
>>> "jarsigner -verify" test fail, so as far as I can tell everything is good.
>>>
>>> What does "the file has been tampered" actually mean?
>>>
>>> Does repository aggregator treat META-INF/eclipse.inf specially?
>>>
>>> Is there a more thorough signature test beyond "jarsigner
>>> -verify" I can do to see the problem?
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> On 12-08-18 5:16 PM, David Williams wrote:
>>>  > The following errors occured when building Kepler:
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.lifecyclemapping.defaults,1.2.0.20120818-2030
>>> in
>>> repository file:/shared/simrel/kepler/aggregation/final/aggregate:
>>> Invalid content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile5398651590436751939.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.core,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile8204237902388499604.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.refactoring,1.2.0.20120818-2030 in
>>> repository file:/shared/simrel/kepler/aggregation/final/aggregate:
>>> Invalid content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile4849163843275710611.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.core.ui,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile5074411570903292693.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.editor,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile7963376606428319461.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.model.edit,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile4278562076904550461.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.launching,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile985416888772393739.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.discovery,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile943022898051933983.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.editor.xml,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile2649689609116490148.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.jdt,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile6945111967795023727.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.scm,1.2.0.20120818-2030 in repository
>>> file:/shared/simrel/kepler/aggregation/final/aggregate: Invalid
>>> content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile8734998429164112130.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.logback.appender,1.2.0.20120818-2030 in
>>> repository file:/shared/simrel/kepler/aggregation/final/aggregate:
>>> Invalid content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile4397856508891381579.jar" has been tampered!
>>>  >
>>>  > org.eclipse.core.runtime.CoreException: Unable to unpack artifact
>>> osgi.bundle,org.eclipse.m2e.logback.configuration,1.2.0.20120818-2030 in
>>> repository file:/shared/simrel/kepler/aggregation/final/aggregate:
>>> Invalid content:META-INF/eclipse.inf
>>>  > Caused by: org.eclipse.osgi.signedcontent.InvalidContentException:
>>> The file "META-INF/eclipse.inf" in the jar
>>> "/tmp/signatureFile2240294073339997116.jar" has been tampered!
>>>  >
>>>  > Check the log file for more information:
>>>
>>> https://hudson.eclipse.org/hudson/view/Repository%20Aggregation/job/simrel.kepler.runaggregator/55/console
>>>  >
>>> _______________________________________________
>>> cross-project-issues-dev mailing list
>>> cross-project-issues-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> cross-project-issues-dev mailing list
>>> cross-project-issues-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>>>
>>