Re: [cross-project-issues-dev] Platform filters and the aggregator

[Stephan Herrmann <stephan@xxxxxxxxxxxxxxx>]

On Tuesday, November 09, 2010 04:55:47 pm Thomas Hallgren wrote:
> On 11/09/2010 03:44 PM, Stephan Herrmann wrote:
> > Hi Thomas,
> >
> >    
> >> Would it be possible for you to simply write one single declaration like
> >> this:
> >>
> >>        <plugin
> >>            id="org.eclipse.objectteams.otequinox.sunjvm"
> >>            os="linux,solaris,win32"
> >>            ... />
> >>
> >> ?
> >>      
> > I could try that, once we have the next successful build (wouldn't help much
> > to further break a broken build, right?).
> > Yet according to Jacek's reply my original version should be correct.

Interestingly the difference is indeed propagated into the metadata:
Your suggestion also folds the three requirements in the feature IU into one
with the combined filter. But I assume that's the expected behavior.

> Yes, never mind. I can't really see anything wrong with the generated 
> meta-data. Can you provide the IU for the fragment too?

Sure. In this case I can't tell what's relevant and what's not so I paste the 
whole thing (different build but otherwise the same story):

    <unit id='org.eclipse.objectteams.otequinox.sunjvm' version='0.8.0.201011091943' singleton='false'>
      <update id='org.eclipse.objectteams.otequinox.sunjvm' range='[0.0.0,0.8.0.201011091943)' severity='0'/>
      <properties size='5'>
        <property name='df_LT.providerName' value='Eclipse.org - Object Teams'/>
        <property name='df_LT.pluginName' value='OT/Equinox SunJVM Fragment (Incubation)'/>
        <property name='org.eclipse.equinox.p2.name' value='%pluginName'/>
        <property name='org.eclipse.equinox.p2.provider' value='%providerName'/>
        <property name='org.eclipse.equinox.p2.bundle.localization' value='plugin'/>
      </properties>
      <provides size='5'>
        <provided namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.objectteams.otequinox.sunjvm' version='0.8.0.201011091943'/>
        <provided namespace='osgi.bundle' name='org.eclipse.objectteams.otequinox.sunjvm' version='0.8.0.201011091943'/>
        <provided namespace='org.eclipse.equinox.p2.eclipse.type' name='bundle' version='1.0.0'/>
        <provided namespace='osgi.fragment' name='org.eclipse.objectteams.otequinox' version='0.8.0.201011091943'/>
        <provided namespace='org.eclipse.equinox.p2.localization' name='df_LT' version='1.0.0'/>
      </provides>
      <requires size='1'>
        <required namespace='osgi.bundle' name='org.eclipse.objectteams.otequinox' range='[0.8.0,0.9.0)'/>
      </requires>
      <filter>
        (|(ogsi.os=solaris)(osgi.os=linux)(osgi.os=win32))
      </filter>
      <artifacts size='1'>
        <artifact classifier='osgi.bundle' id='org.eclipse.objectteams.otequinox.sunjvm' version='0.8.0.201011091943'/>
      </artifacts>
      <touchpoint id='org.eclipse.equinox.p2.osgi' version='1.0.0'/>
      <touchpointData size='1'>
        <instructions size='3'>
          <instruction key='install'>
            addJvmArg(jvmArg:-XX:+UnlockDiagnosticVMOptions); addJvmArg(jvmArg:-XX:+UnsyncloadClass);
          </instruction>
          <instruction key='uninstall'>
            removeJvmArg(jvmArg:-XX:+UnlockDiagnosticVMOptions); removeJvmArg(jvmArg:-XX:+UnsyncloadClass);
          </instruction>
          <instruction key='manifest'>
            Bundle-ManifestVersion: 2&#xA;Fragment-Host: org.eclipse.objectteams.otequinox;bundle-version=&quot;[0.8.0,0.9.0)&quot;&#xA;Bundle-RequiredExecutionEnvironment: J2SE-1.5&#xA;Manifest-Version: 1.0&#xA;Bundle-Version: 0.8.0.201011091943&#xA;Eclipse-PlatformFilter: (|(osgi.os=linux) (osgi.os=win32) (ogsi.os=solaris))&#xA;Bundle-SymbolicName: org.eclipse.objectteams.otequinox.sunjvm&#xA;Bundle-Localization: plugin&#xA;Bundle-Name: %pluginName&#xA;Bundle-Vendor: %providerName
          </instruction>
        </instructions>
      </touchpointData>
    </unit>

anything suspicious?
Stephan