Re: [cross-project-issues-dev] Platform filters and the aggregator

[Jacek Pospychała <jacek.pospychala@xxxxxxxxx>]

PDEBuild never really supported lists on those os/ws/arch fields. So Stephan's feature.xml layout it intentional.

On Tue, Nov 9, 2010 at 2:48 PM, Thomas Hallgren <thomas@xxxxxxx> wrote:

Hi Stephan,

Would it be possible for you to simply write one single declaration like this:

    <plugin
        id="org.eclipse.objectteams.otequinox.sunjvm"

        os="linux,solaris,win32"
        ... />

?

I'm not sure what the problem really is since the aggregator doesn't care much about your feature.xml. It will only consult the p2 meta-data.

HTH,
Thomas Hallgren

PS.
What's the relevance of the fragment="true" in a feature plugin declaration? I know it can be entered, but does it have any purpose?

On 11/09/2010 12:19 PM, Stephan Herrmann wrote:

Hi,

as a train-newbie I had the following issue (which broke a few builds
yesterday, sorry!):
- we have a fragment with a platform filter (only certain OSes)
- the feature conditionally includes this fragment for exactly those OSes
->  the aggregator complains the fragment could not be found,
  although I can't see any inconsistency

Fragment's MANIFEST.MF:
  Bundle-SymbolicName: org.eclipse.objectteams.otequinox.sunjvm
  Eclipse-PlatformFilter: (|(osgi.os=linux) (osgi.os=win32) (ogsi.os=solaris))
  ...
feature.xml:
  ...
     <plugin
         id="org.eclipse.objectteams.otequinox.sunjvm"
         os="linux"
         fragment="true"
         ... />

   <plugin
         id="org.eclipse.objectteams.otequinox.sunjvm"
         os="solaris"
         fragment="true"
         .../>

   <plugin
         id="org.eclipse.objectteams.otequinox.sunjvm"
         os="win32"
         fragment="true"
       .../>

->  The fragment should be available on all platforms that need it, no?

Do you see a bug in my declarations? Does the aggregator need any
further hints to grok this?

Or even better: is any action in the p2 pipeline for supporting
conditional touchpoint actions ( https://bugs.eclipse.org/278657 ) ?
The whole fragment story is only an ugly workaround in order to
provide platform specific -XX arguments to the vm...

TIA
Stephan
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
 

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev