Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] IMPORTANT: Europa RC2 build FAILED due to license file checking


+1.

As an aside, injecting dates into files by the Europa build would invalidate the signature of signed bundles.

Kim




Ed Merks/Toronto/IBM@IBMCA
Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx

05/29/2007 08:59 AM

Please respond to
Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>

To
Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
cc
cross-project-issues-dev-bounces@xxxxxxxxxxx, "'Janet Campbell'" <janet.campbell@xxxxxxxxxxx>, Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>, Philippe P Mulet <philippe_mulet@xxxxxxxxxx>
Subject
Re: [cross-project-issues-dev] IMPORTANT: Europa RC2 build        FAILED        due        to license file checking





Dani,

I expressed similar concerns in the bugzilla that was opened against EMF:

  It seems odd (and questionable) that one would put a future date into a
  file though.  It also seems odd that the rules imply the file should be
  changed even if nothing in the plugin has actually changed.  Perhaps the
  build should just stuff the current build date into these files but that
  begs the question: should these files change in the maintenance stream
  and if so, is it okay that they all change even if the plugin itself
  hasn't actually changed?  I'm concerned about manually needing to update
  yet another field (in many dozens of plugins).  It's hard enough to keep
  the version numbers consistent in a maintenance stream and this problem
  seems directly related, though not quite the same because the version
  number is incremented once for the first change, but this date needs to
  be modified last before a release.

Personally I think we should reconsider the rule itself because I don't
think this rule provides significant value, it's not yet clear that the
rule is well-defined, and it introduces a significant new burden.  We
really don't need more reasons for Europa builds to fail...


Ed Merks/Toronto/IBM@IBMCA
mailto: merks@xxxxxxxxxx
905-413-3265  (t/l 969)




                                                                         
            Daniel Megert                                                
            <daniel_megert@ch                                            
            .ibm.com>                                                  To
            Sent by:                  Cross project issues                
            cross-project-iss         <cross-project-issues-dev@eclipse.o
            ues-dev-bounces@e         rg>                                
            clipse.org                                                 cc
                                      "'Janet Campbell'"                  
                                      <janet.campbell@xxxxxxxxxxx>,      
            05/29/2007 06:43          Philippe P Mulet                    
            AM                        <philippe_mulet@xxxxxxxxxx>        
                                                                  Subject
                                      Re: [cross-project-issues-dev]      
            Please respond to         IMPORTANT: Europa RC2 build FAILED  
              Cross project           due  to license file checking      
                 issues                                                  
            <cross-project-is                                            
            sues-dev@eclipse.                                            
                  org>                                                    
                                                                         
                                                                         




Bjorn,

for all previous releases of the Eclipse SDK we never put the release date
into the about.html but rather the date when this file got provided by the
lawyer. So, it seems we did this all wrong for years. I suggest to define
the release date. It seems odd when every plug-in uses a different random
date in June.

Dani



            Bjorn
            Freeman-Benson
            <bjorn.freeman-be                                          To
            nson@xxxxxxxxxxx>         "eclipse.org-planning-council"
            Sent by:                  <eclipse.org-planning-council@eclip
            cross-project-iss         se.org>, Cross project issues
            ues-dev-bounces@e         <cross-project-issues-dev@eclipse.o
            clipse.org                rg>
                                                                       cc

            29.05.2007 03:51                                      Subject
                                      [cross-project-issues-dev]
                                      IMPORTANT: Europa RC2 build FAILED
            Please respond to         due   to license file checking
              Cross project
                 issues
            <cross-project-is
            sues-dev@eclipse.
                  org>






Europa people,
After our successful (green) Europa RC1 build was promoted, I installed a
new legal/license file checker tool in the Europa-matic tool chain. As a
consequence, almost all projects are failing the build. (See the status and
details for each of your projects on the build status web page.)  In
addition, I will be entering bugs against each project for these license
issues.

Here are the rules/constraints:
     Every plug-in must have an about.html and it must be as described on
     the Eclipse legal website.
           A small number of projects have incorrectly worded about files.
           A larger number of projects have correctly worded about files,
           but with old dates on them. The date must be some time in June
           2007 (I've arbitrarily chosen June 5, 2007, but the tool
           supports "any date in June 2007" as valid). The idea here is
           that the date on the about files is approximately the date of
           the release - just as one updates all the copyright headers
           from 2000-2006 to 2000-2007, one must also update all the
           about.html files to the current date.
           Some number of projects used Microsoft Windows copy-paste to
           create their about files and copied a unicode apostrophe
           character instead of an ASCII one. The tool notes this
           situation so that you can fix it. (And you should/must fix it
           so that the text displays correctly on all platforms.)
     Every feature must have a license.html file.
           The license.html file must contain the full text of all the
           applicable licenses for code in the feature.
           The license.html file must have a bulleted table-of-contents at
           the top of the file listing all the licenses included in the
           file. (This is new.)
           An example of this is coming soon.
           The existence or non-existence of the license.html file is
           currently checked by the tool; the text of the license.html is
           not yet checked but I hope to find a way to add that check this
           week.
     Every feature must have a license section in the feature.xml file
           The feature.xml must contain the full text of the Software User
           Agreement from the Eclipse legal website.
           It must also contain the same bulleted table-of-contents of
           licenses at the top of the file.
           An example of this is coming soon.
           None of this is currently checked by the tool, but it will be
           soon.
Tables of contents should look something like this:
     Eclipse Public License v1.0 (
     http://www.eclipse.org/legal/epl-v10.html)
     Apache License version 2.0 (
     http://www.apache.org/licenses/LICENSE-2.0.html)
     ...
Please let me know if you feel that the checker tool is incorrectly
flagging one of your features or plug-ins - obviously the tool is rote and
dull and not as creative as you or I and there may be valid exceptions that
I am not aware of.

These items are a MUST DO before any project can release in Europa even the
base platform and JDT projects. You may wonder if these is a change from
previous releases and, yes, it is, but only in the sense that in previous
releases we (the EMO) had no way to check these rules automatically and
thus we had to trust that all features and plug-ins were correctly
legalized. Fortunately for us (or unfortunately, depending on which side of
the work items you're on), we now have this first tool of mine and so we
can all correctly add the correct about files, license files, and so on.
While it would have been nice if I'd had this in place earlier, RC2 is
still a good milestone to do this work because feature development should
be over, bug fixes should be winding down, and none of these files have any
executable or configuration information - just words.

- Bjorn
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


Back to the top