[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] name resolution and index bindings

Hi Nathan,

Sorry for dropping the ball on this.ÂCommit http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=52c80c124ee2f4edccf292c472886d9cde8d6143 modified include organizer so that it should not depend on promiscuous binding resolution. The only requirement it has is that the ProblemBindings created because of disabled promiscuous resolution would contain the bindings that would be produced by the promiscuous resolution as the only candidates. We may even introduce a new problem type - BINDING_MISSING_INCLUDE.

I currently don't have much time to spend on this and will appreciate if you can give it a try.

-sergey


On Thu, Jul 9, 2015 at 5:19 PM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:
Hi Sergey,

Any luck with fixing the IncludeOrganizerTest failures for bug 402498?

If you don't have time to work on it but have an idea for how to approach it, I'm happy to give it a try.

Thanks,
Nate

----------------------------------------
> From: zeratul976@xxxxxxxxxxx
> To: cdt-dev@xxxxxxxxxxx
> Date: Fri, 6 Feb 2015 06:37:36 +0000
> Subject: Re: [cdt-dev] name resolution and index bindings
>
> Thanks! I pushed my latest patch (which should pass everything except IncludeOrganizerTest) to gerrit.
>
> Regards,
> Nate
>
> ________________________________
>> Date: Thu, 5 Feb 2015 07:09:02 -0800
>> From: eclipse.sprigogin@xxxxxxxxx
>> To: cdt-dev@xxxxxxxxxxx
>> Subject: Re: [cdt-dev] name resolution and index bindings
>>
>> I'll look into that.
>>
>> -sergey
>>
>> On Wed, Feb 4, 2015 at 11:12 PM, Nathan Ridge
>> <zeratul976@xxxxxxxxxxx<mailto:zeratul976@xxxxxxxxxxx>> wrote:
>> Hi Sergey,
>>
>>>>> I have implemented just the first step (having declaredBefore() for an
>>>>> index binding check if it is declared in an included header), and I'm
>>>>> finding that it doesn't break any tests (but perhaps there's something
>>>>> I'm missing and that the tests don't catch).
>>>>
>>>> This is great. The promiscuous binding resolution bothered me for a
>>>> long time. The change probably didn't break tests because I recently
>>>> changed all index tests to generate proper includes. Glad that it
>>>> appears to work.
>>>
>>> I only ran ParserTestSuite and IndexTests locally. Now that I pushed to
>>> Gerrit and the full suite of tests has run, I see that a few are
>> failing. I'll
>>> investigate.
>>
>> I fixed all the test failures except those in IncludeOrganizerTest.
>>
>> The problem there is that IncludeOrganizer relies on resolveBinding()
>> on a name whose declaration has not been included, still returning the
>> correct binding, so it can figure out what to include.
>>
>> However, without the promiscuous binding resolution, these
>> resolveBinding() calls now return ProblemBindings, and no includes for
>> them are generated.
>>
>> Do you have any ideas for how to handle this?
>>
>> Thanks,
>> Nate
>>
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx<mailto:cdt-dev@xxxxxxxxxxx>
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>
>>
>> _______________________________________________ cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx To change your delivery options, retrieve your
>> password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev