Re: [aspectj-dev] Patch discrepancy here...

[Andy Clement <andrew.clement@xxxxxxxxx>]

We have had a long standing issue to fix the manifests for OSGi. I have tried a couple of times but don't get the feedback I need to confirm what I create are correct - we have no automated tests that verify the validity.  Previously users went to the SpringSource enterprise bundle repo to get a version of the jar that had had bundlor run against it to correct the manifest.  I would much rather we used bundlor/bnd or whatever as part of our build process to ensure they were correct.

> Could you please validate the pull request and include it into the next release?

I'll take a look when I get a minute.

cheers,

Andy

On 9 December 2013 08:16, Lennart Jörelid <lennart.jorelid@xxxxxxxxx> wrote:

Hello Andy,

Currently, the AspectJ dependencies lack sensible OSGi manifest headers to a certain extent.

For example, the current Manifest.MF of the aspectjrt.jar contains the following:

Manifest-Version: 1.0

Name: org/aspectj/lang/

Specification-Title: AspectJ Runtime Classes 

Specification-Version: 1.7

Specification-Vendor: aspectj.org

Implementation-Title: org.aspectj.tools

Implementation-Version: 1.7.4

Implementation-Vendor: aspectj.org

Bundle-Name: AspectJ Runtime

Bundle-Version: 1.7.4

Bundle-Copyright: (C) Copyright 1999-2001 Xerox Corporation, 2002 Palo 

  Alto Research Center, Incorporated (PARC), 2003-2009 Contributors. 

  All Rights Reserved.

However, all packages within the aspectjrt.jar should really be publicly available in an OSGi environment.

I added the presumably correct statement into the aspectjrt5 manifest file template - but since I cannot build AspectJ currently, I cannot validate it.

Could you please validate the pull request and include it into the next release?

2013/12/6 Andy Clement <andrew.clement@xxxxxxxxx>

I fixed that just now (good catch) - it isn't why ajc was suggesting it was 1.7.3 though, that is in org.aspectj.ajdt.ajc/src/org/aspectj/ajdt/ajc/messages.properties - 1.7.4 was done in a bit of a rush unfortunately.

cheers,

Andy

On 4 December 2013 05:54, Lennart Jörelid <lennart.jorelid@xxxxxxxxx> wrote:

I think we may have found a symptom of the 1.7.4 --> 1.7.3 version discrepancy:

Right?

:)

--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: lj@xxxxxxxx
| URL:   www.jguru.se
| Phone
| (skype):    jgurueurope
| (intl):     +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev

--

--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: lj@xxxxxxxx
| URL:   www.jguru.se
| Phone
| (skype):    jgurueurope
| (intl):     +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev