Re: [4diac-dev] Handling of user defined variable names during export

[Martin Melik-Merkumians <Melik-Merkumians@xxxxxxxxxxxxxxxxx>]

Hi,

I am voting +1 for the proposal. With Joses remarks in mind, we should probably put the prefix into a String constant in case we have to change it in the future.
>From today's view I would say var_ should work, and I don't see issues with it right now.

Best regards,
Martin

--------------------------------------------------
Dipl.-Ing. Martin Melik-Merkumians
Advanced Mechatronic Systems
Automation and Control Institute (ACIN)
TU Wien
DVR-Number: 0005886

Gusshausstr. 27-29, room CA-05-38
1040 Vienna, Austria
Phone: +43 (0)1 588 01 37688
Fax: +43 (0)1 588 01 937688
Email: melik-merkumians@xxxxxxxxxxxxxxxxx
http://www.acin.tuwien.ac.at/
--------------------------------------------------

-----Ursprüngliche Nachricht-----
Von: 4diac-dev-bounces@xxxxxxxxxxx <4diac-dev-bounces@xxxxxxxxxxx> Im Auftrag von Jose Cabral
Gesendet: Dienstag, 28. Januar 2020 12:04
An: 4diac developer discussions <4diac-dev@xxxxxxxxxxx>
Betreff: Re: [4diac-dev] Handling of user defined variable names during export

Hi all,

I just got acquainted with the ng exporter. I really like the new proposal. I also had issues in the past with a data input called "operator" which clashed with c++ reserved word.

>From what I see, the change will have the following consequences:
	- The Lua exporter should also be changed according to the new rule
	- The monitoring pluggin should be updated 
	- All the exported FBs already present in FORTE should be re-generated (Caution: there are some generated ones that aren't fully generated)	
	- We should start thinking in adding tests for the exporter

Since this change will be big, we should be pretty sure that "var_" is the right choice. 

Regards

Jose Cabral

--
fortiss · Landesforschungsinstitut des Freistaats Bayern An-Institut Technische Universität München Guerickestraße 25
80805 München
Germany
Tel.: +49 (89) 3603522 529
Fax: +49 (89) 3603522 50
E-Mail: cabral@xxxxxxxxxxx
https://www.fortiss.org/

Amtsgericht München: HRB: 176633
USt-IdNr.: DE263907002, Steuer-Nr.: 143/237/25900
Rechtsform: gemeinnützige GmbH
Sitz der Gesellschaft: München
Geschäftsführer: Dr. Harald Rueß, Thomas Vallon Vorsitzender des Aufsichtsrats: Dr. Manfred Wolter

> -----Ursprüngliche Nachricht-----
> Von: 4diac-dev-bounces@xxxxxxxxxxx <4diac-dev-bounces@xxxxxxxxxxx> Im 
> Auftrag von Alois Zoitl
> Gesendet: Dienstag, 28. Januar 2020 10:25
> An: 4diac-dev@xxxxxxxxxxx
> Betreff: Re: [4diac-dev] Handling of user defined variable names 
> during export
> 
> Hi,
> 
> this is an interesting point. Especially as it would finally also 
> solve our IN/OUT compilation problem for windows. Jose what do you think?
> 
> The only thing I'm not perfectly sure if there are any backwards 
> compatibility issues.
> 
> Cheers,
> Alois
> 
> On Tue, 2020-01-28 at 08:55 +0100, Ernst Blecha wrote:
> > Hi all,
> >
> > during working on the forte_ng export I came across the fact that 
> > all variable names are passed through without change. This might 
> > lead to name clashes or keyword conflicts in the future (e.g. if for 
> > implementing the for loop a temporary variable is needed, any name 
> > given to this variable might overlap with a variable defined by the user).
> >
> > I would propose adding a prefix (e.g. "var_") to all variables and 
> > interfaces, as this would remove the risk of unexpected name clashes.
> >
> >
> > Best regards,
> > Ernst Blecha
> >
> >
> 
> _______________________________________________
> 4diac-dev mailing list
> 4diac-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/4diac-dev