[news.eclipse.tools] DEFECT REPORT: Internal Error when defining an Edit

["Birgit Guder" <bguder@xxxxxx>]

Hi,

I just started using the plugin development tool and wanted to recreate the
readme-plugin step by step.
So I created a plugin project and added an Editor Extension. But whenever I
added a new editor-Element to the Editors-Extension using the Plugin
Manifest Editor I got an Internal Error.
The resulting log-file looked like this:

2 org.eclipse.ui 2 Problems occurred when invoking code from plug-in:
org.eclipse.ui.
java.lang.NullPointerException
 at
org.eclipse.pde.internal.editor.manifest.ExtensionElementPropertySource.getP
ropertyValue(ExtensionElementPropertySource.java:222)
 at
org.eclipse.ui.views.properties.PropertySheetEntry.refreshValues(PropertyShe
etEntry.java:484)
 at
org.eclipse.ui.views.properties.PropertySheetEntry.refreshChildEntries(Prope
rtySheetEntry.java:450)
 at
org.eclipse.ui.views.properties.PropertySheetEntry.setValues(PropertySheetEn
try.java:606)
 at
org.eclipse.ui.views.properties.PropertySheetViewer.setInput(PropertySheetVi
ewer.java:700)
 at
org.eclipse.ui.views.properties.PropertySheetPage.selectionChanged(PropertyS
heetPage.java:219)
....

After a bit of debugging the IDE itself (which is pretty straight forward by
the way, good job) I stumbled over the following code snippet in
ExtensionElementPropertySource.getPropertyValue(Object):
    ...
 if (att == null) {
    if (isEditable() && attInfo != null) {
      if (attInfo.getKind() == ISchemaAttribute.JAVA) {
         IPluginModelBase model = att.getModel();  // NullPointerException
!!
  .....

Since att is null at this point (explicitly tested) this will cause the
above NullPointerException.

The statement should probably look like this:
        IPluginModelBase model = getElement().getModel();

This error occurs both in wsw-beta and eclipse build 0.131.