[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Newsgroup Home]
[news.eclipse.tools.gef] Re: Rotation Tool

Hi,

in the context of GEF3D, we have to support rotation as well. That is, our 3D figures support rotation. But IMHO it is almost impossible to support rotation in GEF without compatibility problems.

We have decided to rotate figures about their center point, which is the standard in 3D applications. Since the location of a figure is the top-left corner of a figure's bound, a rotation may move that point. How do you handle that problem? For example, w/o rotation, the following test will succeed:

figure.setBounds(b);
r = figure.getBounds();
assertEquals(r, b);

Does this test succeed with rotation?

We , that is Kristian, is working on that problem at the moment, and it would be nice to get your opinion in order to make GEF3D compatible with future GEF versions.

Jens


On 2009-03-09 23:02:17 +0100, ctg@xxxxxxxxx (Colin Sharples) said:

To add rotate, but you currently use these bugs for references:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=117012

What is the status of these bugs? Is this going to be included in GEF 3.5?

Okay, so I have taken the code that Hasan contributed for 117012, and I have modified it so that it rotates figures about their center point, rather than about the origin of the bounds. I have also split out rotate, move and resize as three separate operations, which I think makes it a bit easier. It all seems to be working quite nicely now.


How do I go about getting this into GEF? I am assuming that it is already to late for 3.5, so this would be for a future release. I am going to be using this in a commercial product, so I am very keen to make sure that any extensions to GEF that I use end up back in GEF so I don't have to worry about attribution. I'd be happy to do whatever it takes to get this code adopted.