[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
|
[news.eclipse.tools.gef] Re: draw2d.text indent strategy
|
> One concern I have is with getAscent() and getBaseline(). In order to
> ensure that text lines up vertically, all baselines (which does not
> include any insets) must match. I know this is obvious when you're
> working on it, but currently FlowBox's getAscent() returns getHeight().
> This is one of the few places that it should have been "height" =D
Now that I think about it a bit more, it may make sense to expose the
concept of baseline, ascent and descent out through the FlowFigure. If all
FlowFigures on the same line are aligned on their baselines (this is my
assumption) then allowing one to override the baseline (and the ascent and
descent accordingly) would be great for vertically aligning ImageFlow and
generic Figures (if the appropriate wrapper is made).
Good idea?
--
Rob Grzywinski