[news.eclipse.tools.gef] Re: implementing cut/copy/paste

[Jesper Eskilson <jojo@xxxxxxxxxxxx>]

Randy Hudson wrote:
> The registry should hold onto actions maintained by the Editor instance.
> RetargetActions should only be created by the ActionBarContributor, not each
> editor instance.
>
> The purpose of retarget actions is to map a single ActionBarContributor to
> multiple editor instances within a given WorkbenchWindow.  I think actionbar
> contributors were designed as 1-per-window-per-editor-type to reduce flicker
> and repainting when changing between multiple java CU editors.  It also
> reduces the number of native widgets created.

Ok, thanks. The mist is clearing a little now.

The problem was (I think) that I added the retarget-actions to the 
editors registry instead of using addRetargetAction().

So, now I've changed my actionbar-contributor to do the following:

IWorkbenchWindow window = 
PlatformUI.getWorkbench().getActiveWorkbenchWindow();
    	
addRetargetAction((RetargetAction) ActionFactory.CUT.create(window));
addRetargetAction((RetargetAction) ActionFactory.COPY.create(window));
addRetargetAction((RetargetAction) ActionFactory.PASTE.create(window));

but now I get a ClassCastException() in

org.eclipse.ui.actions.RetargetAction.propagateChange(RetargetAction.java:195)

Apparently this mist didn't clear enough. :-)

/Jesper