[ews.eclipse.technology.rap] Re: Selection not working after Dialog post

[Ivan Furnadjiev <ivan@xxxxxxxxxxxxxxxxx>]

Hi Stu,

looking into the code, if the 
CurrentSelectionSourceProvider#updateWindows is called with non null 
argument, the object is a WorkbenchWindow. Anyway... without a snippet 
to reproduce it, we can't do much about it.

Best,
Ivan

Stuart Pond wrote:
> All,
>
> I can not isolate it down to reproducible example to file a bug.  
> However, I was able to following in the debugger that the 
> CurrentSelectionProvider.updateWindows method is getting a bogus shell 
> object in the event.  The shell object is suppose to have a handle to 
> the workbenchWindow in its getData() method. But it does not.  This is 
> why the source provider is never hooked up again to the selection 
> service.
>
> I suspect the listener is listening to the wrong shell, one that has 
> already been disposed.  Any ideas where to look next?
>
> -Stu Pond
> "Ivan Furnadjiev" <ivan@xxxxxxxxxxxxxxxxx> wrote in message 
> news:h887bf$9id$1@xxxxxxxxxxxxxxxxxxxx
> > Hi Stu,
> >
> > if you have a snippet to reproduce your scenario, please file a 
> > bugzilla [1]. The fix for bug 245100 is included in the 1.2 release.
> >
> > [1] http://wiki.eclipse.org/RAP_Bug_Reporting_Howto
> >
> > Best,
> > Ivan
> >
> > Stuart Pond wrote:
> > > Hmmm...  This does sound like a similar if not exactly the same 
> > > problem. However, I am using the release version of RAP 1.2.  Is it 
> > > possible the fix did not make it into the release?  Or the fix was 
> > > not complete?
> > >
> > > -Stu Pond
> > > "Ivan Furnadjiev" <ivan@xxxxxxxxxxxxxxxxx> wrote in message 
> > > news:h87llh$ke1$1@xxxxxxxxxxxxxxxxxxxx
> > > > Hi Stu,
> > > >
> > > > your description points me to this bug, which has been fixed in 1.2M7:
> > > > 245100: Selection changes are not always propagated 
> > > > (ISourceProvider Framework)
> > > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=245100
> > > > Which version of RAP do you use?
> > > >
> > > > Best,
> > > > Ivan
> > > >
> > > > Stuart Pond wrote:
> > > > > All,
> > > > >
> > > > > I have large RCP application we are attempting to run in RAP.  We 
> > > > > notice that once we put up any dialog (e.g. Help->About, or 
> > > > > Window->Show View, Other, etc). then selection is not being 
> > > > > processed the Eclipse command/expression engine properly.  Other 
> > > > > parts of the application (other Views ) still remain able to 
> > > > > respond to changes in the selection service just fine.  However 
> > > > > all the command handlers that have enabledWhen expression see 
> > > > > expression as being null.  Also any Command Handler that uses 
> > > > > HandlerUtil.getCurrentSelection(evt) returns null even though I 
> > > > > know something is selected.
> > > > >
> > > > > The other killer is that when I hit maximize window on my RAP 
> > > > > application then selection starts being processed again by the 
> > > > > command/expression engine correctly until any dialog is shown 
> > > > > again and then it stops working again.
> > > > >
> > > > > Of course when I try to re-create this with RCP Mail Template 
> > > > > application, I am unable.  So I would not be surprised there is 
> > > > > something in our code crossing wires here with Eclipse.
> > > > >
> > > > > Any pointers where to look or to check would be greatly appreciated.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Stu Pond