[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[news.eclipse.technology.ercp] Spec issue in MultipageDialog

I have noticed a few javadoc issues in MultipageDialog.

1) close method defines that the dialog may be disposed on close but I think 
this conflicts with having is dispose() method We should either remove
"Note: This method may dispose the dialog. The receiver should not be used 
after this call is made." from the spec or we should not have a dispose 
method. I would like to keep the dispose method since it enables us to reuse 
the same dialog without the need to create the pages of the MultipageDialog 
again.

2.) The javadoc for dispose method references isDisposed() method but 
MultipageDialog does not have isDisposed method. I suggest that the javadoc 
corrected as follows.

"Disposes of the operating system resources associated with the receiver.. 
After this method has been invoked, all descendents will answer true when 
sent the message isDisposed(). Any internal connections between the widgets 
in the tree will have been removed to facilitate garbage collection"

3.) Also dispose() throws a ERROR_WIDGET_DISPOSED  but this is not 
consistent with Widget.dispose() this should be aligned with the 
Widget.dispose();

--
Gorkem