[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Newsgroup Home]
[news.eclipse.technology.eilf] Re: [Xml Storage] API :: first draft

Hi,

Am 05.05.2008, 17:06 Uhr, schrieb tmenzel <tmenzel@xxxxxxx>:
Hi folks,

I have just checked in the first draft of the XML storage API under https://svn.brox.de/svn/eccenca/EILF/trunk/org.eclipse.eilf.xmlstorage

comments and ideas are welcome. tomorrow I will update the wiki accordingly.

just had a look at it. It's basically OK to me. Just two remarks:
- I'm not sure about the getConnection(ConnectionConfig) method, but it depends
on what will be contained in the ConnectionConfig: A client should not have to
know about where a database server is running and how to connect (authentication),
this should be hidden by the service configuration. If ConnectionConfig is meant
to describe this, then I think we do not need this method. If it is meant to
contain just connection parameters like e.g. switching transactional behaviour
on and off or other things to tune the connection for the conversation to follow,
it's ok. I hope it get's clear what I want to say (-;
- About the XssConnection methods: I wonder if we could need bulk mehods like
addRecords(Record[]), or simply make the existing methods take a variable number
of arguments, e.g. addRecord(Record...) to be able optimize performance?


Cheers,
Juergen.