[news.eclipse.modeling.gmf] EMF GMF integration

[Daniel OKOUYA <okouya_d@xxxxxxxx>]

Title: EMF GMF integration

Dear aLL,

There is something I can;t understand when following the classic prodecure of integrating EMF and GMF. More specifically


I can’t see the purpose of continuing to create the EMF editor generated adapterFactory while the shared editing domain do not make any use of it. 



protected void initializeEditingDomain() {
    // Create an adapter factory that yields item providers.
    //
    adapterFactory = new ComposedAdapterFactory(ComposedAdapterFactory.Descriptor.Registry.INSTANCE);

    adapterFactory.addAdapterFactory(new ResourceItemProviderAdapterFactory());
    adapterFactory.addAdapterFactory(new TopicmapItemProviderAdapterFactory());
    adapterFactory.addAdapterFactory(new ReflectiveItemProviderAdapterFactory());

    // Create a transactional editing domain
    //
    TransactionalEditingDomain domain = TransactionalEditingDomain.Factory.INSTANCE.createEditingDomain();
    domain.setID("org.example.emfgmf.diagram.EditingDomain");
      
    // Add a listener to set the most recent command's affected objects to be the selection of the viewer with focus.
    // 
    domain.getCommandStack().addCommandStackListener(
        new CommandStackListener() {
          public void commandStackChanged(final EventObject event) {
            getContainer().getDisplay().asyncExec
              (new Runnable() {
                public void run() {
                  firePropertyChange(IEditorPart.PROP_DIRTY);

                // Try to select the affected objects.
                //
                Command mostRecentCommand = ((CommandStack) event.getSource()).getMostRecentCommand();
                if (mostRecentCommand != null) {
                  setSelectionToViewer(mostRecentCommand.getAffectedObjects());
                }
                if (propertySheetPage != null && !propertySheetPage.getControl().isDisposed()) {
                  propertySheetPage.refresh();
                }
              }
            });
          }
        });
        
      editingDomain = (AdapterFactoryEditingDomain) domain;
  }





The actual code in the generated EMF editor which use the base classe AdapterFactoryEditing domain, in contrast clearly use it:

protected void initializeEditingDomain() {
        // Create an adapter factory that yields item providers.
        //
        adapterFactory = new ComposedAdapterFactory(ComposedAdapterFactory.Descriptor.Registry.INSTANCE);

        adapterFactory.addAdapterFactory(new ResourceItemProviderAdapterFactory());
        adapterFactory.addAdapterFactory(new OperaItemProviderAdapterFactory());
        adapterFactory.addAdapterFactory(new OMItemProviderAdapterFactory());
        adapterFactory.addAdapterFactory(new ReflectiveItemProviderAdapterFactory());

        // Create the command stack that will notify this editor as commands are executed.
        //
        BasicCommandStack commandStack = new BasicCommandStack();

        // Add a listener to set the most recent command's affected objects to be the selection of the viewer with focus.
        //
        commandStack.addCommandStackListener
            (new CommandStackListener() {
                 public void commandStackChanged(final EventObject event) {
                     getContainer().getDisplay().asyncExec
                         (new Runnable() {
                              public void run() {
                                  firePropertyChange(IEditorPart.PROP_DIRTY);

                                  // Try to select the affected objects.
                                  //
                                  Command mostRecentCommand = ((CommandStack)event.getSource()).getMostRecentCommand();
                                  if (mostRecentCommand != null) {
                                      setSelectionToViewer(mostRecentCommand.getAffectedObjects());
                                  }
                                  if (propertySheetPage != null && !propertySheetPage.getControl().isDisposed()) {
                                      propertySheetPage.refresh();
                                  }
                              }
                          });
                 }
             });

        // Create the editing domain with a special command stack.
        //
        editingDomain = new AdapterFactoryEditingDomain(adapterFactory, commandStack, new HashMap<Resource, Boolean>());
    }



Does any one have an idea that explain that? If they use the same editing domain, shouldn’t the transactionalediting domain make use of the adapter factory. That should be the way the Transactionaleditingdomain should access the EMF generated Item adapters for edition purpose? Or does it Actually make no use of the AdapterFactory created by EMF? If yes then, why do we keep it (adapterFactory)?



Regards,
Daniel