| Re: [wtp-releng] WTP 3.10.0.M6 issue - features changed from INCLUDE to REQUIRE |
Probably too late to fix for M6 since it's +1 day. I don't hear you saying this is a blocker, just an annoyance.This is due to changing from INCLUDE to REQUIRE in feature.xml to conform with Tycho 1.1 requirements (which we had to do to support JDK 9).We can probably change some of them back to the old way, but this change helped me find all the places where the projects were failing to publish sources, tests, docs, plugins, or features. Or where SDK features included sources from previous builds instead of the locally built ones, due in part to the dangers of the -Pintegration flag. Or where the SDK features were simply wrappers for other features, providing no sources or other useful functionality other than being a single feature instead of 2-3 features... a feature-of-convenience, if you will.I can explore reverting some or most of these include-to-require changes along with the changes to bump versions when I enable the baseline checks to use Oxygen.3 instead of Neon. As I mentioned on the call on Thurs, I expect we may find lots of IUs which have not been correctly upversioned for the Photon release.In the meantime, you could instruct your IBM teams to use p2.mirror against a larger set of plugins/features.Here's a more complete list of IUs from which you could generate a p2.mirror script:You could also ask them to test more often, since there have been A Great Many CI builds of WTP since October 4, and this problem could have been reported, caught, and fixed more quickly had they reported it to you or me.cc:'ing wider audience so more are aware.Cheers,Nick--On Mon, Mar 12, 2018 at 6:36 PM, Carl Anderson <ccc@xxxxxxxxxx> wrote:Nick,There is at least one team within IBM that is having an issue with the structure of WTP 3.10 (which has changed drastically since the October WTP 3.10 declare)- here is some of the information that I was sent:With the builds from October and earlier, I just have to specify the ~40 feature groups in Eclipse p2.mirror to download/install WTP. The feature groups will include and download all the required plugins.
The feature groups in the recent WTP 3.10 builds do not seem to include all the required plugins. I had to specify hundreds individual plugins in Eclipse p2.mirror to download/install WTP.In our old 4.8.0 M5 build which included the October WTP 3.10.0 I-3.10.0-20171004000115 build, org.eclipse.jst.web_sdk.feature group included a hierarchy of sub feature groups In a recent 4.8.0 M6 build which included the recent WTP 3.10.0 I-3.10.0-20180309052619 build, org.eclipse.jst.web_sdk.feature group was flattened and did not include any sub feature groups
This is happening to many other feature groups too. At least the following feature groups are now missing and this is causing problems with our 4.8.0 M6 builds.
org.eclipse.wst.ws_ui.feature.feature.group
org.eclipse.wst.server_ui.feature.feature.group
org.eclipse.wst.common_ui.feature.feature.group I thought I would raise this issue since it effects an adopter. Is this due to the massive restructuring of the categories? And is there anything that we can do about this for M6?FWIW,- Carl Anderson
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com