Re: [wtp-releng] compilation error in JSF -- please merge these fixes

[Nick Boldt <nboldt@xxxxxxxxxx>]

BTW this is also breaking the 3.9.3 builds since JSF contributes its master branch to that build too. 

https://ci.eclipse.org/webtools/job/WTP-R3_9_x_Maintenance/267/console

Ian, if you'd like to not have to worry about these types of changes, feel free to nominate me as a committer so I can fix builds w/o needing to bug you. :)

Thanks,

Nick

On Fri, Feb 23, 2018 at 9:07 AM, Nick Boldt <nboldt@xxxxxxxxxx> wrote:

[ERROR] /jobs/genie.webtools/WTP-R3_10_Integration/workspace/webtools.jsf/jsf/tests/org.eclipse.jst.jsf.test.util/src/org/eclipse/jst/jsf/test/util/mock/java/MockJavaProject.java:[25] 
[ERROR] 	public class MockJavaProject extends MockJavaElement implements IJavaProject
[ERROR] 	             ^^^^^^^^^^^^^^^
[ERROR] The type MockJavaProject must implement the inherited abstract method IJavaProject.findUnfilteredPackageFragmentRoots(IClasspathEntry)
[ERROR] 279 problems (1 error, 278 warnings)

-- https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/291/console

>> fix: https://git.eclipse.org/r/#/c/118050/ << 

I've also got a couple other commits to merge, which will:

* https://git.eclipse.org/r/118049 - add source to the update site (REQUIRED)

* https://git.eclipse.org/r/118051 - update project settings for the above failing test (optional, feel free to reject if you don't want those updates)

Thanks!

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews      Red Hat

“The Only Thing That Is Constant Is Change” - Heraclitus

--

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED.

@ @redhatnews      Red Hat

“The Only Thing That Is Constant Is Change” - Heraclitus