OK,
I was just going to create a new bug, when saw that there is another opened issue about not opening a diagram editor in Mars:
478960. I guess it can be used for the creation of the feature patch? And my last question before starting the preparation of this feature patch is, who is supposed to create the new branch
R3_5_patches?
Thanks again and regards,
Petya
From: wtp-releng-bounces@xxxxxxxxxxx [mailto:wtp-releng-bounces@xxxxxxxxxxx]
On Behalf Of Carl Anderson
Sent: Friday, April 8, 2016 12:44 AM
To: Webtools releng discussion list
Subject: Re: [wtp-releng] JPA Diagram editor not working for Eclipse Mars 2 (new public feature patch is needed)
Neil and Petya,
Sorry for the delay on this- Neon M6 and the removal of many deprecated classes have caused quite a stir amongst IBM adopters, and I have been tied up in that. What we found out right before our Neon M6 candidate would have saved a lot of time and effort if
we had done it for our Mars.2 candidate- deleting the Hudson workspace deletes the cached versions and forces a rebuild. That was all we needed to do, but now we need a feature patch.
We have done feature patches since moving to CBI. The last one was the Apache Commons Collections one for WTP 3.7.1. It will take me a few days to set up another build (I've been so busy lately that I still have not set up the patch build for WTP 3.6.3 for
the Apache Commons Collections issue).
FWIW,
- Carl Anderson
WTP Releng project leader
Neil
Hauge ---04/07/2016 03:31:58 PM---Petya, To answer your questions. Yes, we would need a bug for the feature patch request. I don’t t
From: Neil Hauge <neil.hauge@xxxxxxxxxx>
To: Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
Date: 04/07/2016 03:31 PM
Subject: Re: [wtp-releng] JPA Diagram editor not working for Eclipse Mars 2 (new public feature patch is needed)
Sent by: wtp-releng-bounces@xxxxxxxxxxx
Petya,
To answer your questions. Yes, we would need a bug for the feature patch request. I don’t think it needs to be marked as a hot-bug. I would would need PMC review.
Carl, and others,
Have we done a feature patch since moving to the new CBI infra? I was just wondering if there was a standard procedure that we were following for this, or whether the old standard procedure needs to change.
Neil
On Apr 5, 2016, at 8:04 AM, Sabeva, Petya <petya.sabeva@xxxxxxx>
wrote:
Hi all,
The JPA Diagram editor is not working for Eclipse Mars 2. As described in
Bug 472835, the reason is a buildtime dependency. Few weeks before
Mars 2 became GA, I updated the feature level dependency, requiring a newer version of the Graphiti project. I thought that with this change, the whole JPA Diagram editor project will be rebuild, but actually only the diagram editor’s feature was updated.
It took me some time to figure out that only features/plugins that contains changes will be automatically rebuild and by that time it was already too late to respin the WTP build. So as Harald Albert has already
commented in the bug, the current state of the JPA diagram editor
become even worse. That’s why I would like to make a feature patch.
The change that will be added with this feature path is a minor and the risk of breaking something is very low. I’ve already submitted it in the master branch and it works fine:
http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=5a6557eaeb06cba8f5e98b6e58ea7842f18e2aec
I found this wiki,
describing how to make a feature patch publicity available, but still have some questions:
·
Should I open a bug for that issue
· Should it be marked as hot-bug
· Do I need PMC reviews
So, I will be thankful for any other information on how to make a public feature patch.
Regards,
Petya
_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-releng
_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-releng
